-
Notifications
You must be signed in to change notification settings - Fork 47.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Tutorial should not mention getDOMNode #8935
Comments
These are not the current docs, it's just @chenglou’s old fork :-) The docs are here: https://facebook.github.io/react/docs/tutorial.html Hope this helps! |
Crap, why is my page ranked so high on google? |
Must be all your thoughtleadering! |
Thanks. Cheng, maybe you could take down your old pages so they don't confuse other beginners like me? |
Unfortunately this would still be an issue for any of 10K forks of React. Maybe we can add some detection code that adds a banner to the top of the doc page? |
@jaredbeck through which link did you access my fork? |
That would be better than nothing. I'm worried that I just spent a few hours learning some outdated techniques. :(
I don't remember, sorry. |
For whatever reason you got linked to my fork; It doesn't make sense for me to delete mine, or Dan's, or whoever else's. I can't disable my gh-pages; but I've updated it to the latest react#gh-pages. This way if anyone stumbles upon my fork they'll at least see up-to-date info. |
The current live docs at https://chenglou.github.io/react/docs/tutorial.html contain the following incorrect example:
According to https://facebook.github.io/react/blog/2015/10/07/react-v0.14.html,
so, perhaps the example should be changed to
I tried to click on the "Edit on GitHub" link at the top of the tutorial, but got a 404. So, the only thing I could think to do was to open an issue. Hope it helps.
Thanks. ❤️
The text was updated successfully, but these errors were encountered: