Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SVG renders children="[Object object]" into DOM #6165

Closed
zpao opened this issue Mar 2, 2016 · 2 comments · Fixed by #6164
Closed

SVG renders children="[Object object]" into DOM #6165

zpao opened this issue Mar 2, 2016 · 2 comments · Fixed by #6164
Assignees
@gaearon
Labels
SVG
Milestone
15.0

Comments

@zpao
Copy link
Member

zpao commented Mar 2, 2016

See http://jsfiddle.net/e91q5089/ for a basic example.

I'm assuming there's some step in the new SVG code that we just need to remove the children key if we consume it as a React prop.
@zpao zpao added the SVG label Mar 2, 2016
@zpao zpao added this to the 15.0 milestone Mar 2, 2016
@zpao
Copy link
Member Author

zpao commented Mar 2, 2016

Going to leave this open to ensure we block even though @gaearon wrote fix before I finished submitting (do you ever sleep Dan!?)

@gaearon
Copy link
Collaborator

gaearon commented Mar 2, 2016

I sleep incrementally.
FWIW the fix is in #6164.

@gaearon gaearon mentioned this issue Mar 2, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gaearon gaearon

Labels
SVG
Projects
None yet
Milestone
15.0
Development

Successfully merging a pull request may close this issue.

Don't set children attribute on SVG nodes
2 participants
@zpao @gaearon