Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encoding declaration have been written in several ways #4347

Closed
makky3939 opened this issue Jul 11, 2015 · 4 comments
Closed

Encoding declaration have been written in several ways #4347

makky3939 opened this issue Jul 11, 2015 · 4 comments

Comments

@makky3939
Copy link
Contributor

From the react/examples:

Encoding is declared as described below. In the 9 files.

https://github.com/facebook/react/blame/master/examples/basic-jsx-external/index.html#L4
<meta http-equiv='Content-type' content='text/html; charset=utf-8'>

However, in another example it has been declared in another writing.

https://github.com/facebook/react/blob/master/examples/jquery-mobile/index.html#L4
<meta charset="utf-8">

I think that we should unify to the latter way. In HTML5, it is possible to provide a short code by using the charset attribute.

@jimfb
Copy link
Contributor

jimfb commented Jul 11, 2015

@spicyj @zpao Are we assuming HTML5 at this point, or are we aiming for backwards compatibility?

@sophiebits
Copy link
Contributor

IIRC the HTML5 meta charset tag, as with the doctype, was chosen because older browsers already interpreted it properly.

@jimfb
Copy link
Contributor

jimfb commented Jul 11, 2015

oic, ok, so it sounds like this is a reasonable/desirable thing for us to do.

@makky3939
Copy link
Contributor Author

ok, I'll create pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants