Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace setInnerHTML with createNodesFromMarkup/getMarkupWrap #2273

Closed
syranide opened this issue Sep 29, 2014 · 2 comments
Closed

Replace setInnerHTML with createNodesFromMarkup/getMarkupWrap #2273

syranide opened this issue Sep 29, 2014 · 2 comments
Labels
Type: Enhancement

Comments

@syranide
Copy link
Contributor

From #2249, I found that setInnerHTML and createNodesFromMarkup (which calls getMarkupWrap) both solve largely the same problem and includes the same fixes for IE8.

Submitting this issue as a reminder to myself and for your information.
@syranide syranide mentioned this issue Sep 29, 2014
Closed
@syranide
Copy link
Contributor Author

cc @zpao @sebmarkbage You know of any reason why this should not be done? Otherwise I'll go ahead and draft a PR for this.

@syranide syranide mentioned this issue Sep 29, 2014
Closed
This was referenced Oct 12, 2014
Merged
Closed
@gaearon
Copy link
Collaborator

gaearon commented Oct 27, 2016

Probably not relevant now that we use createElement on the client.

@gaearon gaearon closed this as completed Oct 27, 2016
This was referenced Jun 21, 2021
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gaearon @syranide