Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship 0.11.2 #2137

Closed
4 tasks done
zpao opened this issue Sep 3, 2014 · 16 comments
Closed
4 tasks done

Ship 0.11.2 #2137

zpao opened this issue Sep 3, 2014 · 16 comments
Assignees

Comments

@zpao
Copy link
Member

zpao commented Sep 3, 2014

I think we want to get React.createElement out there. We can take some ridealongs for new elements or properties or any non-breaking bug fixes. List them if you have them.

@zpao zpao self-assigned this Sep 3, 2014
@zpao zpao added the release label Sep 3, 2014
@sophiebits
Copy link
Contributor

Can we have .key and .ref on the descriptor (and still in props) in this release to allow people to switch to using .key when appropriate for future-looking code? @sebmarkbage

@sophiebits
Copy link
Contributor

Can we have createFactory too? Trying to preemptively start fixing up KA code (before upgrading React) and it's easier if I can do it all now instead of having to do it synchronously with the upgrade.

@kossnocorp
Copy link

Please increase minor version if you adding something to API. See issue in immutable-js.

@sebmarkbage
Copy link
Collaborator

I thought we already has createFactory?

On Sep 4, 2014, at 12:51 AM, Ben Alpert notifications@github.com wrote:

Can we have createFactory too? Trying to preemptively start fixing up KA code (before upgrading React) and it's easier if I can do it all now instead of having to do it synchronously with the upgrade.


Reply to this email directly or view it on GitHub.

@sophiebits
Copy link
Contributor

Me too but it doesn't seem to be in 0.11.1.

@sebmarkbage
Copy link
Collaborator

We didn't need an intermediate release for key/ref because it is greppable. You can probably find your uses using just grep. We did. So I figured it would be ok to play hardball on that one. We've always introduced some breaking change with releases without deprecating them first.

Do you foresee trouble upgrading at KA?

On Sep 4, 2014, at 12:47 AM, Ben Alpert notifications@github.com wrote:

Can we have .key and .ref on the descriptor (and still in props) in this release to allow people to switch to using .key when appropriate for future-looking code? @sebmarkbage


Reply to this email directly or view it on GitHub.

@sophiebits
Copy link
Contributor

No, shouldn't be a big deal.

@syranide
Copy link
Contributor

syranide commented Sep 4, 2014

Ping @sebmarkbage #1988 (no rush from my side, just a reminder)

@zpao
Copy link
Member Author

zpao commented Sep 8, 2014

@kossnocorp We won't be bumping the minor version even if we add a couple small things. Right now PATCH really is our MINOR.

  1. Major version zero (0.y.z) is for initial development. Anything may change at any time. The public API should not be considered stable.
    semver

I totally understand your argument though and I'm not trying to be rude, just letting you know we're taking advantage of the "fuck the other rules pre-1.0" rule while we can. API additions are for transitional purposes while updating your own codebase. We won't break or change existing APIs though. We're trying to be as interop and semver as possible while sticking to a slower-moving schedule (it's not practical for us to bump versions at the rate of say browserify). When we get to 1.0, the plan is to be much more strict about the real rules.

@mtscout6
Copy link

mtscout6 commented Sep 9, 2014

What is the issue or commit related to React.createElement so I can start getting familiar with the upcoming change?

@jeffchan
Copy link
Contributor

jeffchan commented Sep 9, 2014

@zpao
Copy link
Member Author

zpao commented Sep 9, 2014

@mtscout6 it's currently in 0.11.x as createDescriptor, which just calls the function it's passed. It will be more involved/versatile in 0.12

@zpao
Copy link
Member Author

zpao commented Sep 11, 2014

@syranide you mentioned #1988 here but I don't think we should take it in the branch. Did you want it there or just reminding @sebmarkbage in as many places as possible?

@syranide
Copy link
Contributor

@zpao Just a reminder, push ahead :)

@mtscout6
Copy link

How does the JSX React.createElement change work with the core proposal on stateless functions?

@zpao zpao mentioned this issue Sep 16, 2014
@zpao
Copy link
Member Author

zpao commented Sep 16, 2014

http://facebook.github.io/react/blog/2014/09/16/react-v0.11.2.html

cdnjs and jsdelivr should be set up to pick up the changes from npm/bower automatically. I think that's all folks.

@zpao zpao closed this as completed Sep 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants