-
Notifications
You must be signed in to change notification settings - Fork 46.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ship 0.11.2 #2137
Comments
Can we have |
Can we have createFactory too? Trying to preemptively start fixing up KA code (before upgrading React) and it's easier if I can do it all now instead of having to do it synchronously with the upgrade. |
Please increase minor version if you adding something to API. See issue in immutable-js. |
I thought we already has createFactory?
|
Me too but it doesn't seem to be in 0.11.1. |
We didn't need an intermediate release for key/ref because it is greppable. You can probably find your uses using just grep. We did. So I figured it would be ok to play hardball on that one. We've always introduced some breaking change with releases without deprecating them first. Do you foresee trouble upgrading at KA?
|
No, shouldn't be a big deal. |
Ping @sebmarkbage #1988 (no rush from my side, just a reminder) |
@kossnocorp We won't be bumping the minor version even if we add a couple small things. Right now PATCH really is our MINOR.
I totally understand your argument though and I'm not trying to be rude, just letting you know we're taking advantage of the "fuck the other rules pre-1.0" rule while we can. API additions are for transitional purposes while updating your own codebase. We won't break or change existing APIs though. We're trying to be as interop and semver as possible while sticking to a slower-moving schedule (it's not practical for us to bump versions at the rate of say browserify). When we get to 1.0, the plan is to be much more strict about the real rules. |
What is the issue or commit related to |
@mtscout6 it's currently in 0.11.x as createDescriptor, which just calls the function it's passed. It will be more involved/versatile in 0.12 |
@syranide you mentioned #1988 here but I don't think we should take it in the branch. Did you want it there or just reminding @sebmarkbage in as many places as possible? |
@zpao Just a reminder, push ahead :) |
How does the JSX |
http://facebook.github.io/react/blog/2014/09/16/react-v0.11.2.html cdnjs and jsdelivr should be set up to pick up the changes from npm/bower automatically. I think that's all folks. |
I think we want to get
React.createElement
out there. We can take some ridealongs for new elements or properties or any non-breaking bug fixes. List them if you have them.The text was updated successfully, but these errors were encountered: