You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I don't remember if there's a good reason for this, but it makes debugging production builds of DevTools difficult (on the occasion that it needs to be done).
Let's enable cheap source maps for DEV mode (like most configs already do) and full source maps for the production builds. Might be worth comparing before and after build times and bundle sizes for the extensions. We may also need to explicitly add the source maps to the extension manifests web_accessible_resources.
The text was updated successfully, but these errors were encountered:
I've added the "good first issue (taken)" label so that others will know not to start work on the issue. If you change your mind about the issue, no worries! Just let me know so that I can remove the label and free it up for someone else to claim.
Source maps are currently disabled for DevTools production builds:
react/packages/react-devtools-core/webpack.backend.js
Line 22 in 38a512a
react/packages/react-devtools-shell/webpack.config.js
Line 28 in 38a512a
react/packages/react-devtools-inline/webpack.config.js
Line 20 in 38a512a
react/packages/react-devtools-core/webpack.standalone.js
Line 22 in 38a512a
react/packages/react-devtools-extensions/webpack.config.js
Line 21 in 38a512a
react/packages/react-devtools-extensions/webpack.backend.js
Line 21 in 38a512a
I don't remember if there's a good reason for this, but it makes debugging production builds of DevTools difficult (on the occasion that it needs to be done).
Let's enable cheap source maps for DEV mode (like most configs already do) and full source maps for the production builds. Might be worth comparing before and after build times and bundle sizes for the extensions. We may also need to explicitly add the source maps to the extension manifests
web_accessible_resources
.The text was updated successfully, but these errors were encountered: