Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable source maps for DevTools production builds #19769

Closed
bvaughn opened this issue Sep 4, 2020 · 2 comments
Closed

Enable source maps for DevTools production builds #19769

bvaughn opened this issue Sep 4, 2020 · 2 comments

Comments

@bvaughn
Copy link
Contributor

bvaughn commented Sep 4, 2020

Source maps are currently disabled for DevTools production builds:

devtool: __DEV__ ? 'cheap-module-eval-source-map' : false,

devtool: __DEV__ ? 'cheap-module-eval-source-map' : false,

devtool: __DEV__ ? 'cheap-module-eval-source-map' : false,

devtool: __DEV__ ? 'cheap-module-eval-source-map' : false,

I don't remember if there's a good reason for this, but it makes debugging production builds of DevTools difficult (on the occasion that it needs to be done).

Let's enable cheap source maps for DEV mode (like most configs already do) and full source maps for the production builds. Might be worth comparing before and after build times and bundle sizes for the extensions. We may also need to explicitly add the source maps to the extension manifests web_accessible_resources.

@jpribyl
Copy link
Contributor

jpribyl commented Sep 4, 2020

I can take a look at this one!

@bvaughn
Copy link
Contributor Author

bvaughn commented Sep 4, 2020

This issue is all yours @jpribyl! 😄

I've added the "good first issue (taken)" label so that others will know not to start work on the issue. If you change your mind about the issue, no worries! Just let me know so that I can remove the label and free it up for someone else to claim.

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants