Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workbox plugin to 5.1.2 resolving ServiceWorker quota exceeded errors #18579

Closed
jflayhart opened this issue Apr 11, 2020 · 1 comment
Closed
Labels
Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug

Comments

@jflayhart
Copy link

jflayhart commented Apr 11, 2020

Currently our e-commerce site is experiencing millions of ServiceWorker DOMException: QuotaExceededError errors, which is blowing through our monthly Rollbar limit 😬. I did some brief research and found that Google is aware of this issue and recommends purgeOnQuotaError to potentially fix most of these runtime quota issues.

I could be mistaken, but looks as if CRA is using workbox 4.3.1, and this purgeOnQuotaError was added in 5.1.2 as default enabled.

Being that we at Shipt use CRA, since it follows best practice standards, I highly suggest we update Workbox plugin ASAP so we can be on par with Google's best practices for handling ServiceWorkers.

I would love to do the PR myself, but wanted to post here for thoughts or concerns. Although, I would be surprised if anyone is opposed to not following Google's recommendations by updating workbox 👍

Thanks and love this app!

@jflayhart jflayhart added the Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug label Apr 11, 2020
@jflayhart
Copy link
Author

jflayhart commented Apr 11, 2020

haha oops i had too many tabs open, meant to post in CRA!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug
Projects
None yet
Development

No branches or pull requests

2 participants
@jflayhart and others