Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow on attribute for amp interactions #16189

Closed
dpuscher opened this issue Jul 24, 2019 · 1 comment
Closed

Allow on attribute for amp interactions #16189

dpuscher opened this issue Jul 24, 2019 · 1 comment

Comments

@dpuscher
Copy link

Do you want to request a feature or report a bug?
A feature

What is the current behavior?
Since React 16 we have the ability to define any attribute and it is passed to the DOM (contrary to the whitelisting approach of earlier versions). An exception are all attributes starting with on - for obvious security reasons. (Source)
However, this restriction makes it impossible to write interactive AMP pages in React, since all actions are defined using the on attribute. (Example)

What is the expected behavior?
It should be possible to use the on attribute, so that it is also passed to the DOM.

Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?
All React Versions

@dpuscher
Copy link
Author

Closed because it is a bug in styled components.

styled-components/styled-components#2689

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant