Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

16.8 regression: react-dom/test-utils no longer require()-able in pure node #14764

Closed
AviVahl opened this issue Feb 6, 2019 · 2 comments · Fixed by #14768
Closed

16.8 regression: react-dom/test-utils no longer require()-able in pure node #14764

AviVahl opened this issue Feb 6, 2019 · 2 comments · Fixed by #14768
Assignees

Comments

@AviVahl
Copy link

AviVahl commented Feb 6, 2019

Do you want to request a feature or report a bug?
Bug. Behavior regression.

What is the current behavior?
Package throws when being required in Node.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem. Your bug will get fixed much faster if we can run your code and it doesn't have dependencies other than React. Paste the link to your JSFiddle (https://jsfiddle.net/Luktwrdm/) or CodeSandbox (https://codesandbox.io/s/new) example below:

avi@localhost  ~/projects/r168  node
> require('react-dom/test-utils')
ReferenceError: document is not defined
    at /home/avi/projects/r168/node_modules/react-dom/cjs/react-dom-test-utils.development.js:944:27
    at Object.<anonymous> (/home/avi/projects/r168/node_modules/react-dom/cjs/react-dom-test-utils.development.js:1283:5)
    at Module._compile (internal/modules/cjs/loader.js:689:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:700:10)
    at Module.load (internal/modules/cjs/loader.js:599:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:538:12)
    at Function.Module._load (internal/modules/cjs/loader.js:530:3)
    at Module.require (internal/modules/cjs/loader.js:637:17)
    at require (internal/modules/cjs/helpers.js:22:18)

What is the expected behavior?
react-dom/test-utils should not throw in "pure" node (without jsdom providing fake document on global).

Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?
happens on 16.8.0
previous versions work.

@ghost
Copy link

ghost commented Feb 6, 2019

We also got this issue after upgrading to 16.8.0

ReferenceError: document is not defined

at node_modules/react-dom/cjs/react-dom-test-utils.development.js:944:27
at Object.<anonymous> (node_modules/react-dom/cjs/react-dom-test-utils.development.js:1283:5)
at Object.<anonymous> (node_modules/react-dom/test-utils.js:6:20)
at Object.<anonymous> (node_modules/enzyme-adapter-react-16/build/ReactSixteenAdapter.js:31:18)

@BenRevell96
Copy link

BenRevell96 commented Feb 6, 2019

Found the fix and putting together a PR now 👍

edit: @threepointone now on the case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants
@threepointone @AviVahl @BenRevell96 and others