Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seal or Prevent Extensions on Pooled Events #13224

Closed
gaearon opened this issue Jul 17, 2018 · 2 comments
Closed

Seal or Prevent Extensions on Pooled Events #13224

gaearon opened this issue Jul 17, 2018 · 2 comments
Labels
React Core Team Opened by a member of the React Core Team Type: Breaking Change
Milestone
19.0.0

Comments

@gaearon
Copy link
Collaborator

gaearon commented Jul 17, 2018 •
edited
Loading

I'm going to revert I have reverted #5947 because it's very confusing to see Proxies in the console. The warning is just not worth the debugging impediment.

In the future, we should consider sealing or preventing extensions to pooled events (if we're not getting rid of pooling altogether, that is). But that would be a breaking change.
@gaearon gaearon added this to the 17.0.0 milestone Jul 17, 2018
@gaearon gaearon mentioned this issue Jul 17, 2018
Merged
@gaearon
Copy link
Collaborator Author

gaearon commented Jul 17, 2018 •
edited
Loading

I guess that was the original proposal in #5853 anyway

@poeschko poeschko mentioned this issue Sep 11, 2018
Closed
@necolas necolas added the React Core Team Opened by a member of the React Core Team label Jan 8, 2020
@gaearon
Copy link
Collaborator Author

gaearon commented Mar 24, 2021

We don't have pooled events now.

@gaearon gaearon closed this as completed Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
React Core Team Opened by a member of the React Core Team Type: Breaking Change
Projects
None yet
Milestone
19.0.0
Development

No branches or pull requests
2 participants
@necolas @gaearon