Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RN] Remove unstable_batchedUpdates and unmountComponentAtNodeAndRemoveContainer from Fabric #12571

Merged
merged 1 commit into from
Apr 10, 2018

Conversation

sebmarkbage
Copy link
Collaborator

These don't make much sense in Fabric, since Fabric will be async by default only.

And unmount+remove container is a sketchy API we should remove so we might as well make sure modern containers enforce that. It's not functional in Fabric anyway.

…veContainer from Fabric

These don't make much sense in Fabric, since Fabric will be async by default only.

And unmount+remove container is a sketchy API we should remove so we might
as well make sure modern containers enforce that.
@@ -75,8 +71,6 @@ const ReactFabric: ReactNativeType = {
return ReactPortal.createPortal(children, containerTag, null, key);
},

unstable_batchedUpdates: ReactGenericBatching.batchedUpdates,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we at some point switch this to be the only ReactNative export, then we might need to add a noop with a warning here just for legacy purposes.

@sebmarkbage
Copy link
Collaborator Author

@fkgozali We'll need to update the call in Surface to use unmountComponentAtNode instead. Although long term we need a better solution for async unmounting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants