Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate why Flow fails on Windows #11703

Closed
gaearon opened this issue Nov 29, 2017 · 2 comments
Closed

Investigate why Flow fails on Windows #11703

gaearon opened this issue Nov 29, 2017 · 2 comments

Comments

@gaearon
Copy link
Collaborator

gaearon commented Nov 29, 2017

I couldn't enable it on Windows CI: https://ci.appveyor.com/project/Facebook/react/build/1.0.10

I also remember seeing this locally on a Windows machine. Need to investigate why yarn flow fails on Windows but works on macOS.

yarn run v1.3.2
$ node ./scripts/tasks/flow.js
Error: packages/react-reconciler/src/ReactFiberHostContext.js:87
 87:     const nextContext = getChildHostContext(context, fiber.type, rootInstance);
                                                 ^^^^^^^ NoContextT. This type is incompatible with the expected param type of
                    v--------------------------------------------
 31: export default function<T, P, I, TI, HI, PI, C, CC, CX, PL>(
 32:   config: HostConfig<T, P, I, TI, HI, PI, C, CC, CX, PL>,
 33: ): HostContext<C, CX> {
     --------------------^ some incompatible instantiation of `CX`
Error: packages/react-reconciler/src/ReactFiberHostContext.js:87
 87:     const nextContext = getChildHostContext(context, fiber.type, rootInstance);
                                                                      ^^^^^^^^^^^^ NoContextT. This type is incompatible with the expected param type of
                    v--------------------------------------------
 31: export default function<T, P, I, TI, HI, PI, C, CC, CX, PL>(
 32:   config: HostConfig<T, P, I, TI, HI, PI, C, CC, CX, PL>,
 33: ): HostContext<C, CX> {
     --------------------^ some incompatible instantiation of `C`
Found 2 errors
Flow failed
error Command failed with exit code 2.
@raphamorim
Copy link
Contributor

I'll see it 👍

@raphamorim
Copy link
Contributor

raphamorim commented Dec 18, 2017

@gaearon I forget to ref this issue to close :octocat:

@gaearon gaearon closed this as completed Dec 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants