Fix warning message for new setNativeProps method. on -> with (#14909)

facebook · Feb 21, 2019 · f978d5f · f978d5f
1 parent b0f45c0
commit f978d5f
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/packages/react-native-renderer/src/ReactNativeRendererSharedExports.js b/packages/react-native-renderer/src/ReactNativeRendererSharedExports.js
@@ -19,7 +19,7 @@ export function setNativeProps(handle: any, nativeProps: Object): void {
   if (handle._nativeTag == null) {
     warningWithoutStack(
       handle._nativeTag != null,
-      "setNativeProps was called on a ref that isn't a " +
+      "setNativeProps was called with a ref that isn't a " +
         'native component. Use React.forwardRef to get access to the underlying native component',
     );
     return;

diff --git a/packages/react-native-renderer/src/__tests__/ReactFabric-test.internal.js b/packages/react-native-renderer/src/__tests__/ReactFabric-test.internal.js
@@ -287,7 +287,7 @@ describe('ReactFabric', () => {
         ReactFabric.setNativeProps(viewRef, {foo: 'baz'});
       }).toWarnDev(
         [
-          "Warning: setNativeProps was called on a ref that isn't a " +
+          "Warning: setNativeProps was called with a ref that isn't a " +
             'native component. Use React.forwardRef to get access ' +
             'to the underlying native component',
         ],

diff --git a/packages/react-native-renderer/src/__tests__/ReactNativeMount-test.internal.js b/packages/react-native-renderer/src/__tests__/ReactNativeMount-test.internal.js
@@ -218,7 +218,7 @@ describe('ReactNative', () => {
         ReactNative.setNativeProps(viewRef, {foo: 'baz'});
       }).toWarnDev(
         [
-          "Warning: setNativeProps was called on a ref that isn't a " +
+          "Warning: setNativeProps was called with a ref that isn't a " +
             'native component. Use React.forwardRef to get access ' +
             'to the underlying native component',
         ],