From f5e404ce343c0798561184bc1fe5f7e88423f3d4 Mon Sep 17 00:00:00 2001 From: Gordon Dent Date: Tue, 31 Oct 2017 23:04:48 -0700 Subject: [PATCH] Rename variables to be more semantic --- .../src/__tests__/ReactDOMComponentTree-test.js | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/packages/react-dom/src/__tests__/ReactDOMComponentTree-test.js b/packages/react-dom/src/__tests__/ReactDOMComponentTree-test.js index c52744af18319..19ae5a87efff2 100644 --- a/packages/react-dom/src/__tests__/ReactDOMComponentTree-test.js +++ b/packages/react-dom/src/__tests__/ReactDOMComponentTree-test.js @@ -79,10 +79,11 @@ describe('ReactDOMComponentTree', () => { }); it('finds closest instance for node when an event happens', () => { - const elemID = 'aID'; - const innerHTML = {__html: `
`}; - const testID = 'closestInstance'; + const nonReactElemID = 'aID'; + const innerHTML = {__html: `
`}; + const closestInstanceID = 'closestInstance'; let currentTargetID = null; + class ClosestInstance extends React.Component { _onClick = e => { currentTargetID = e.currentTarget.id; @@ -90,7 +91,7 @@ describe('ReactDOMComponentTree', () => { render() { return (
@@ -103,8 +104,8 @@ describe('ReactDOMComponentTree', () => { ReactDOM.render(
{component}
, container); document.body.appendChild(container); expect(currentTargetID).toBe(null); - simulateClick(document.getElementById(elemID)); - expect(currentTargetID).toBe(testID); + simulateClick(document.getElementById(nonReactElemID)); + expect(currentTargetID).toBe(closestInstanceID); }); it('finds a controlled instance from node and gets its current fiber props', () => {