From cf7a0c24d4640f07d465c5a67aab2639ddd5d0a9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sebastian=20Markb=C3=A5ge?= Date: Tue, 21 Jan 2020 19:43:35 -0800 Subject: [PATCH] Remove dynamic GKs for selective/train (#17888) There are shipped/shipping. --- packages/shared/ReactFeatureFlags.js | 2 +- packages/shared/forks/ReactFeatureFlags.native-fb.js | 2 +- packages/shared/forks/ReactFeatureFlags.native-oss.js | 2 +- packages/shared/forks/ReactFeatureFlags.persistent.js | 2 +- packages/shared/forks/ReactFeatureFlags.test-renderer.js | 2 +- packages/shared/forks/ReactFeatureFlags.test-renderer.www.js | 2 +- packages/shared/forks/ReactFeatureFlags.www.js | 5 +++-- 7 files changed, 9 insertions(+), 8 deletions(-) diff --git a/packages/shared/ReactFeatureFlags.js b/packages/shared/ReactFeatureFlags.js index 92de043bde508..6705b683cf4c3 100644 --- a/packages/shared/ReactFeatureFlags.js +++ b/packages/shared/ReactFeatureFlags.js @@ -84,7 +84,7 @@ export const warnAboutDefaultPropsOnFunctionComponents = false; export const disableSchedulerTimeoutBasedOnReactExpirationTime = false; -export const enableTrainModelFix = __EXPERIMENTAL__; +export const enableTrainModelFix = true; export const enableTrustedTypesIntegration = false; diff --git a/packages/shared/forks/ReactFeatureFlags.native-fb.js b/packages/shared/forks/ReactFeatureFlags.native-fb.js index aa1207833522d..0fac92224c125 100644 --- a/packages/shared/forks/ReactFeatureFlags.native-fb.js +++ b/packages/shared/forks/ReactFeatureFlags.native-fb.js @@ -43,7 +43,7 @@ export const warnAboutDefaultPropsOnFunctionComponents = false; export const warnAboutStringRefs = false; export const disableLegacyContext = false; export const disableSchedulerTimeoutBasedOnReactExpirationTime = false; -export const enableTrainModelFix = false; +export const enableTrainModelFix = true; export const enableTrustedTypesIntegration = false; export const disableCreateFactory = false; export const disableTextareaChildren = false; diff --git a/packages/shared/forks/ReactFeatureFlags.native-oss.js b/packages/shared/forks/ReactFeatureFlags.native-oss.js index a1be3463007be..1ab71e94964cb 100644 --- a/packages/shared/forks/ReactFeatureFlags.native-oss.js +++ b/packages/shared/forks/ReactFeatureFlags.native-oss.js @@ -37,7 +37,7 @@ export const warnAboutDefaultPropsOnFunctionComponents = false; export const warnAboutStringRefs = false; export const disableLegacyContext = false; export const disableSchedulerTimeoutBasedOnReactExpirationTime = false; -export const enableTrainModelFix = false; +export const enableTrainModelFix = true; export const enableTrustedTypesIntegration = false; export const enableNativeTargetAsInstance = false; export const disableCreateFactory = false; diff --git a/packages/shared/forks/ReactFeatureFlags.persistent.js b/packages/shared/forks/ReactFeatureFlags.persistent.js index be3d33df47a7f..995cb081cdb21 100644 --- a/packages/shared/forks/ReactFeatureFlags.persistent.js +++ b/packages/shared/forks/ReactFeatureFlags.persistent.js @@ -37,7 +37,7 @@ export const warnAboutDefaultPropsOnFunctionComponents = false; export const warnAboutStringRefs = false; export const disableLegacyContext = false; export const disableSchedulerTimeoutBasedOnReactExpirationTime = false; -export const enableTrainModelFix = false; +export const enableTrainModelFix = true; export const enableTrustedTypesIntegration = false; export const enableNativeTargetAsInstance = false; export const disableCreateFactory = false; diff --git a/packages/shared/forks/ReactFeatureFlags.test-renderer.js b/packages/shared/forks/ReactFeatureFlags.test-renderer.js index 6639964ab60f1..4f8251d196b9d 100644 --- a/packages/shared/forks/ReactFeatureFlags.test-renderer.js +++ b/packages/shared/forks/ReactFeatureFlags.test-renderer.js @@ -37,7 +37,7 @@ export const warnAboutDefaultPropsOnFunctionComponents = false; export const warnAboutStringRefs = false; export const disableLegacyContext = false; export const disableSchedulerTimeoutBasedOnReactExpirationTime = false; -export const enableTrainModelFix = false; +export const enableTrainModelFix = true; export const enableTrustedTypesIntegration = false; export const enableNativeTargetAsInstance = false; export const disableCreateFactory = false; diff --git a/packages/shared/forks/ReactFeatureFlags.test-renderer.www.js b/packages/shared/forks/ReactFeatureFlags.test-renderer.www.js index dd7574f36c968..514d532333f8c 100644 --- a/packages/shared/forks/ReactFeatureFlags.test-renderer.www.js +++ b/packages/shared/forks/ReactFeatureFlags.test-renderer.www.js @@ -35,7 +35,7 @@ export const warnAboutDefaultPropsOnFunctionComponents = false; export const warnAboutStringRefs = false; export const disableLegacyContext = false; export const disableSchedulerTimeoutBasedOnReactExpirationTime = false; -export const enableTrainModelFix = false; +export const enableTrainModelFix = true; export const enableTrustedTypesIntegration = false; export const enableNativeTargetAsInstance = false; export const disableCreateFactory = false; diff --git a/packages/shared/forks/ReactFeatureFlags.www.js b/packages/shared/forks/ReactFeatureFlags.www.js index 26b72b387e8cb..cf14d167f297c 100644 --- a/packages/shared/forks/ReactFeatureFlags.www.js +++ b/packages/shared/forks/ReactFeatureFlags.www.js @@ -15,8 +15,6 @@ export const { debugRenderPhaseSideEffectsForStrictMode, disableInputAttributeSyncing, enableTrustedTypesIntegration, - enableSelectiveHydration, - enableTrainModelFix, } = require('ReactFeatureFlags'); // In www, we have experimental support for gathering data @@ -39,9 +37,12 @@ export const warnAboutStringRefs = false; export const warnAboutDefaultPropsOnFunctionComponents = false; export const disableSchedulerTimeoutBasedOnReactExpirationTime = false; +export const enableTrainModelFix = true; + export const exposeConcurrentModeAPIs = __EXPERIMENTAL__; export const enableSuspenseServerRenderer = true; +export const enableSelectiveHydration = true; export const enableChunksAPI = __EXPERIMENTAL__;