- Uncaught Error: {errorMessage || ''}
+
+
+ Uncaught Error: {errorMessage || ''}
+
+ {dismissError !== null && (
+
+ )}
{!!callStack && (
diff --git a/packages/react-devtools-shared/src/devtools/views/ErrorBoundary/shared.css b/packages/react-devtools-shared/src/devtools/views/ErrorBoundary/shared.css
index 267cfad7b7e886..05988649e01cfe 100644
--- a/packages/react-devtools-shared/src/devtools/views/ErrorBoundary/shared.css
+++ b/packages/react-devtools-shared/src/devtools/views/ErrorBoundary/shared.css
@@ -37,12 +37,22 @@
overflow: auto;
}
-.Header {
+.HeaderRow {
+ display: flex;
+ flex-direction: row;
font-size: var(--font-size-sans-large);
font-weight: bold;
color: var(--color-error-text);
}
+.Header {
+ flex: 1 1 auto;
+ overflow: hidden;
+ text-overflow: ellipsis;
+ white-space: nowrap;
+ min-width: 0;
+}
+
.Stack {
margin-top: 0.5rem;
white-space: pre-wrap;
@@ -75,9 +85,13 @@
.ReproSteps {
margin-left: 0.25rem;
color: var(--color-console-warning-text);
+ overflow: hidden;
+ text-overflow: ellipsis;
+ white-space: nowrap;
+ min-width: 0;
}
.UpdateExistingIssuePrompt {
margin-right: 0.25rem;
color: var(--color-console-warning-text);
-}
\ No newline at end of file
+}
diff --git a/packages/react-devtools-shared/src/hook.js b/packages/react-devtools-shared/src/hook.js
index d636a683d526b3..a4724f6f6b92b0 100644
--- a/packages/react-devtools-shared/src/hook.js
+++ b/packages/react-devtools-shared/src/hook.js
@@ -261,13 +261,6 @@ export function installHook(target: any): DevToolsHook | null {
return roots[rendererID];
}
- function onClonedForForceRemount(rendererID, oldFiber, newFiber) {
- const rendererInterface = rendererInterfaces.get(rendererID);
- if (rendererInterface != null) {
- rendererInterface.handleClonedForForceRemount(oldFiber, newFiber);
- }
- }
-
function onCommitFiberUnmount(rendererID, fiber) {
const rendererInterface = rendererInterfaces.get(rendererID);
if (rendererInterface != null) {
@@ -313,7 +306,6 @@ export function installHook(target: any): DevToolsHook | null {
// Fast Refresh for web relies on this.
renderers,
- onClonedForForceRemount,
emit,
getFiberRoots,
diff --git a/packages/react-reconciler/src/ReactFiberBeginWork.new.js b/packages/react-reconciler/src/ReactFiberBeginWork.new.js
index 44dc1caefeeb60..2dfc6766577f95 100644
--- a/packages/react-reconciler/src/ReactFiberBeginWork.new.js
+++ b/packages/react-reconciler/src/ReactFiberBeginWork.new.js
@@ -32,10 +32,6 @@ import type {UpdateQueue} from './ReactUpdateQueue.new';
import checkPropTypes from 'shared/checkPropTypes';
-import {
- isDevToolsPresent,
- onClonedForForceRemount,
-} from './ReactFiberDevToolsHook.new';
import {
IndeterminateComponent,
FunctionComponent,
@@ -3198,21 +3194,19 @@ function beginWork(
if (__DEV__) {
if (workInProgress._debugNeedsRemount && current !== null) {
- const clonedWorkInProgress = createFiberFromTypeAndProps(
- workInProgress.type,
- workInProgress.key,
- workInProgress.pendingProps,
- workInProgress._debugOwner || null,
- workInProgress.mode,
- workInProgress.lanes,
- );
-
- if (isDevToolsPresent) {
- onClonedForForceRemount(workInProgress, clonedWorkInProgress);
- }
-
// This will restart the begin phase with a new fiber.
- return remountFiber(current, workInProgress, clonedWorkInProgress);
+ return remountFiber(
+ current,
+ workInProgress,
+ createFiberFromTypeAndProps(
+ workInProgress.type,
+ workInProgress.key,
+ workInProgress.pendingProps,
+ workInProgress._debugOwner || null,
+ workInProgress.mode,
+ workInProgress.lanes,
+ ),
+ );
}
}
diff --git a/packages/react-reconciler/src/ReactFiberBeginWork.old.js b/packages/react-reconciler/src/ReactFiberBeginWork.old.js
index a3293218e9ea51..7c9df820b98c53 100644
--- a/packages/react-reconciler/src/ReactFiberBeginWork.old.js
+++ b/packages/react-reconciler/src/ReactFiberBeginWork.old.js
@@ -32,10 +32,6 @@ import type {UpdateQueue} from './ReactUpdateQueue.old';
import checkPropTypes from 'shared/checkPropTypes';
-import {
- isDevToolsPresent,
- onClonedForForceRemount,
-} from './ReactFiberDevToolsHook.old';
import {
IndeterminateComponent,
FunctionComponent,
@@ -3198,21 +3194,19 @@ function beginWork(
if (__DEV__) {
if (workInProgress._debugNeedsRemount && current !== null) {
- const clonedWorkInProgress = createFiberFromTypeAndProps(
- workInProgress.type,
- workInProgress.key,
- workInProgress.pendingProps,
- workInProgress._debugOwner || null,
- workInProgress.mode,
- workInProgress.lanes,
- );
-
- if (isDevToolsPresent) {
- onClonedForForceRemount(workInProgress, clonedWorkInProgress);
- }
-
// This will restart the begin phase with a new fiber.
- return remountFiber(current, workInProgress, clonedWorkInProgress);
+ return remountFiber(
+ current,
+ workInProgress,
+ createFiberFromTypeAndProps(
+ workInProgress.type,
+ workInProgress.key,
+ workInProgress.pendingProps,
+ workInProgress._debugOwner || null,
+ workInProgress.mode,
+ workInProgress.lanes,
+ ),
+ );
}
}
diff --git a/packages/react-reconciler/src/ReactFiberDevToolsHook.new.js b/packages/react-reconciler/src/ReactFiberDevToolsHook.new.js
index 9d2f9243a2752a..e7bde59e20cbaf 100644
--- a/packages/react-reconciler/src/ReactFiberDevToolsHook.new.js
+++ b/packages/react-reconciler/src/ReactFiberDevToolsHook.new.js
@@ -166,28 +166,3 @@ export function onCommitUnmount(fiber: Fiber) {
}
}
}
-
-export function onClonedForForceRemount(
- oldWorkInProgress: Fiber,
- newWorkInProgress: Fiber,
-) {
- if (
- injectedHook &&
- typeof injectedHook.onClonedForForceRemount === 'function'
- ) {
- try {
- injectedHook.onClonedForForceRemount(
- rendererID,
- oldWorkInProgress,
- newWorkInProgress,
- );
- } catch (err) {
- if (__DEV__) {
- if (!hasLoggedError) {
- hasLoggedError = true;
- console.error('React instrumentation encountered an error: %s', err);
- }
- }
- }
- }
-}
diff --git a/packages/react-reconciler/src/ReactFiberDevToolsHook.old.js b/packages/react-reconciler/src/ReactFiberDevToolsHook.old.js
index 198e6233c0b9d4..494138685e1045 100644
--- a/packages/react-reconciler/src/ReactFiberDevToolsHook.old.js
+++ b/packages/react-reconciler/src/ReactFiberDevToolsHook.old.js
@@ -166,28 +166,3 @@ export function onCommitUnmount(fiber: Fiber) {
}
}
}
-
-export function onClonedForForceRemount(
- oldWorkInProgress: Fiber,
- newWorkInProgress: Fiber,
-) {
- if (
- injectedHook &&
- typeof injectedHook.onClonedForForceRemount === 'function'
- ) {
- try {
- injectedHook.onClonedForForceRemount(
- rendererID,
- oldWorkInProgress,
- newWorkInProgress,
- );
- } catch (err) {
- if (__DEV__) {
- if (!hasLoggedError) {
- hasLoggedError = true;
- console.error('React instrumentation encountered an error: %s', err);
- }
- }
- }
- }
-}
diff --git a/packages/react-reconciler/src/ReactFiberHotReloading.new.js b/packages/react-reconciler/src/ReactFiberHotReloading.new.js
index 61ce24224c3e3b..4c9eaf010125c2 100644
--- a/packages/react-reconciler/src/ReactFiberHotReloading.new.js
+++ b/packages/react-reconciler/src/ReactFiberHotReloading.new.js
@@ -318,7 +318,6 @@ function scheduleFibersWithFamiliesRecursively(
if (needsRemount) {
fiber._debugNeedsRemount = true;
}
-
if (needsRemount || needsRender) {
scheduleUpdateOnFiber(fiber, SyncLane, NoTimestamp);
}
diff --git a/packages/react-reconciler/src/ReactFiberHotReloading.old.js b/packages/react-reconciler/src/ReactFiberHotReloading.old.js
index 475b449541d160..ee0616fae79c0b 100644
--- a/packages/react-reconciler/src/ReactFiberHotReloading.old.js
+++ b/packages/react-reconciler/src/ReactFiberHotReloading.old.js
@@ -318,7 +318,6 @@ function scheduleFibersWithFamiliesRecursively(
if (needsRemount) {
fiber._debugNeedsRemount = true;
}
-
if (needsRemount || needsRender) {
scheduleUpdateOnFiber(fiber, SyncLane, NoTimestamp);
}