Extract commit root cache cleanup into a function, handle error case

Author: josephsavona

packages/react-reconciler/src/ReactFiberWorkLoop.new.js

@@ -2053,7 +2053,7 @@ function commitRootImpl(root, renderPriorityLevel) {
     hasUncaughtError = false;
     const error = firstUncaughtError;
     firstUncaughtError = null;
-    // TODO: how to handle cache cleanup here?
+    releaseRootPooledCache(root);
     throw error;
   }
 
@@ -2096,13 +2096,7 @@ function commitRootImpl(root, renderPriorityLevel) {
 
   // Now that effects have run - giving Cache boundaries a chance to retain the
   // cache instance - release the root's cache in case since the render is complete
-  if (enableCache) {
-    const pooledCache = root.pooledCache;
-    if (pooledCache != null) {
-      releaseCache(pooledCache);
-      root.pooledCache = null;
-    }
-  }
+  releaseRootPooledCache(root);
 
   if (__DEV__) {
     if (enableDebugTracing) {
@@ -2117,6 +2111,16 @@ function commitRootImpl(root, renderPriorityLevel) {
   return null;
 }
 
+function releaseRootPooledCache(root) {
+  if (enableCache) {
+    const pooledCache = root.pooledCache;
+    if (pooledCache != null) {
+      releaseCache(pooledCache);
+      root.pooledCache = null;
+    }
+  }
+}
+
 export function flushPassiveEffects(): boolean {
   // Returns whether passive effects were flushed.
   // TODO: Combine this check with the one in flushPassiveEFfectsImpl. We should