From 8065990dd8d2bcd2e1e4385e72e748e24d03f999 Mon Sep 17 00:00:00 2001 From: Joe Savona Date: Wed, 28 Aug 2024 10:52:35 -0700 Subject: [PATCH] Update base for Update on "[compiler] Allow inferred non-optional paths when manual deps were optional" If the inferred deps are more precise (non-optional) than the manual deps (optional) it should pass validation. The other direction also seems like it would be fine - inferring optional deps when the original was non-optional - but for now let's keep the "at least as precise" rule. [ghstack-poisoned] --- .../ReactiveScopes/MergeReactiveScopesThatInvalidateTogether.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/compiler/packages/babel-plugin-react-compiler/src/ReactiveScopes/MergeReactiveScopesThatInvalidateTogether.ts b/compiler/packages/babel-plugin-react-compiler/src/ReactiveScopes/MergeReactiveScopesThatInvalidateTogether.ts index 21f2140f4c137..08d2212d86b95 100644 --- a/compiler/packages/babel-plugin-react-compiler/src/ReactiveScopes/MergeReactiveScopesThatInvalidateTogether.ts +++ b/compiler/packages/babel-plugin-react-compiler/src/ReactiveScopes/MergeReactiveScopesThatInvalidateTogether.ts @@ -8,7 +8,6 @@ import {CompilerError} from '..'; import { DeclarationId, - DependencyPath, InstructionId, InstructionKind, Place,