[Transition Tracing] Fix Cache and Transitions Pop Order (#24719)

We push the Cache before the transition so we should pop the transition before the cache. This PR fixes this issue.
facebook · Jun 14, 2022 · 54f17e4 · 54f17e4
1 parent be229c5
commit 54f17e4
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/packages/react-reconciler/src/ReactFiberTransition.new.js b/packages/react-reconciler/src/ReactFiberTransition.new.js
@@ -139,13 +139,13 @@ export function pushTransition(
 
 export function popTransition(workInProgress: Fiber, current: Fiber | null) {
   if (current !== null) {
-    if (enableCache) {
-      pop(resumedCache, workInProgress);
-    }
-
     if (enableTransitionTracing) {
       pop(transitionStack, workInProgress);
     }
+
+    if (enableCache) {
+      pop(resumedCache, workInProgress);
+    }
   }
 }
 

diff --git a/packages/react-reconciler/src/ReactFiberTransition.old.js b/packages/react-reconciler/src/ReactFiberTransition.old.js
@@ -139,13 +139,13 @@ export function pushTransition(
 
 export function popTransition(workInProgress: Fiber, current: Fiber | null) {
   if (current !== null) {
-    if (enableCache) {
-      pop(resumedCache, workInProgress);
-    }
-
     if (enableTransitionTracing) {
       pop(transitionStack, workInProgress);
     }
+
+    if (enableCache) {
+      pop(resumedCache, workInProgress);
+    }
   }
 }