Skip to content

Commit

Permalink
[Native] Delete NativeComponent and NativeMethodsMixin (#18036)
Browse files Browse the repository at this point in the history
* [Native] Delete NativeComponent and NativeMethodsMixin

* Remove more files
  • Loading branch information
elicwhite authored Feb 13, 2020
1 parent d4f2b03 commit 2d6be75
Show file tree
Hide file tree
Showing 10 changed files with 260 additions and 1,257 deletions.
330 changes: 0 additions & 330 deletions packages/react-native-renderer/src/NativeMethodsMixin.js

This file was deleted.

9 changes: 1 addition & 8 deletions packages/react-native-renderer/src/ReactFabric.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,6 @@ import ReactVersion from 'shared/ReactVersion';
// Module provided by RN:
import {UIManager} from 'react-native/Libraries/ReactPrivate/ReactNativePrivateInterface';

import NativeMethodsMixin from './NativeMethodsMixin';
import ReactNativeComponent from './ReactNativeComponent';
import {getClosestInstanceFromNode} from './ReactFabricComponentTree';
import {getInspectorDataForViewTag} from './ReactNativeFiberInspector';

Expand Down Expand Up @@ -155,8 +153,6 @@ setBatchingImplementation(
const roots = new Map();

const ReactFabric: ReactFabricType = {
NativeComponent: ReactNativeComponent(findNodeHandle, findHostInstance),

// This is needed for implementation details of TouchableNativeFeedback
// Remove this once TouchableNativeFeedback doesn't use cloneElement
findHostInstance_DEPRECATED,
Expand Down Expand Up @@ -223,10 +219,7 @@ const ReactFabric: ReactFabricType = {
return createPortal(children, containerTag, null, key);
},

__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED: {
// Used as a mixin in many createClass-based components
NativeMethodsMixin: NativeMethodsMixin(findNodeHandle, findHostInstance),
},
__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED: {},
};

injectIntoDevTools({
Expand Down
Loading

0 comments on commit 2d6be75

Please sign in to comment.