From 26001f6ca26734b7f8d1802a6b8cb1a0455a92ae Mon Sep 17 00:00:00 2001 From: Brian Vaughn Date: Sat, 17 Nov 2018 09:04:27 -0800 Subject: [PATCH] Removed version check --- package.json | 2 +- .../release/create-canary-commands/build-artifacts.js | 10 +--------- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/package.json b/package.json index 9f3d3d0970d80e..f6829548c0a66a 100644 --- a/package.json +++ b/package.json @@ -93,7 +93,7 @@ "testRegex": "/scripts/jest/dont-run-jest-directly\\.js$" }, "scripts": { - "build": "npm run version-check && node ./scripts/rollup/build.js", + "build": "node ./scripts/rollup/build.js", "linc": "node ./scripts/tasks/linc.js", "lint": "node ./scripts/tasks/eslint.js", "lint-build": "node ./scripts/rollup/validate/index.js", diff --git a/scripts/release/create-canary-commands/build-artifacts.js b/scripts/release/create-canary-commands/build-artifacts.js index 6466819cd42a4b..3435a625b584d1 100644 --- a/scripts/release/create-canary-commands/build-artifacts.js +++ b/scripts/release/create-canary-commands/build-artifacts.js @@ -12,15 +12,7 @@ const run = async ({cwd, dry, tempDirectory}) => { }; await exec('yarn install', defaultOptions); - - // We run rollup directly to avoid the version check. - // It's expected that canary package version and renderer version mismatch. - // Canaries version numbers use the format of 0.0.0- to be easily recognized (e.g. 0.0.0-57239eac8). - // A separate "React version" is used for the embedded renderer version to support DevTools, - // since it needs to distinguish between different version ranges of React. - // It is based on the version of React in the local package.json (e.g. 16.6.1-canary-57239eac8). - // Both numbers will be replaced if the canary is promoted to a stable release. - await exec('node ./scripts/rollup/build.js --extract-errors', defaultOptions); + await exec('yarn build -- --extract-errors', defaultOptions); const tempNodeModulesPath = join(tempDirectory, 'build', 'node_modules'); const buildPath = join(cwd, 'build');