From 01bce8c24843b02a0082edb55d3cd4763e7a956d Mon Sep 17 00:00:00 2001 From: Eli White Date: Mon, 11 Nov 2019 11:22:41 -0800 Subject: [PATCH] Change legacy-events plugin nativeEventTarget to allow null (#17344) --- packages/legacy-events/EventPluginHub.js | 4 ++-- packages/legacy-events/PluginModuleType.js | 2 +- packages/react-dom/src/events/SimpleEventPlugin.js | 2 +- .../react-native-renderer/src/ReactNativeBridgeEventPlugin.js | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/legacy-events/EventPluginHub.js b/packages/legacy-events/EventPluginHub.js index f5068ff39b18e..8d503640fcd1b 100644 --- a/packages/legacy-events/EventPluginHub.js +++ b/packages/legacy-events/EventPluginHub.js @@ -134,7 +134,7 @@ function extractPluginEvents( topLevelType: TopLevelType, targetInst: null | Fiber, nativeEvent: AnyNativeEvent, - nativeEventTarget: EventTarget, + nativeEventTarget: null | EventTarget, eventSystemFlags: EventSystemFlags, ): Array | ReactSyntheticEvent | null { let events = null; @@ -161,7 +161,7 @@ export function runExtractedPluginEventsInBatch( topLevelType: TopLevelType, targetInst: null | Fiber, nativeEvent: AnyNativeEvent, - nativeEventTarget: EventTarget, + nativeEventTarget: null | EventTarget, eventSystemFlags: EventSystemFlags, ) { const events = extractPluginEvents( diff --git a/packages/legacy-events/PluginModuleType.js b/packages/legacy-events/PluginModuleType.js index d6728427e874f..1e7635114f779 100644 --- a/packages/legacy-events/PluginModuleType.js +++ b/packages/legacy-events/PluginModuleType.js @@ -27,7 +27,7 @@ export type PluginModule = { topLevelType: TopLevelType, targetInst: null | Fiber, nativeTarget: NativeEvent, - nativeEventTarget: EventTarget, + nativeEventTarget: null | EventTarget, eventSystemFlags: EventSystemFlags, ) => ?ReactSyntheticEvent, tapMoveThreshold?: number, diff --git a/packages/react-dom/src/events/SimpleEventPlugin.js b/packages/react-dom/src/events/SimpleEventPlugin.js index f7103071ad1c0..90f6cbbb90631 100644 --- a/packages/react-dom/src/events/SimpleEventPlugin.js +++ b/packages/react-dom/src/events/SimpleEventPlugin.js @@ -250,7 +250,7 @@ const SimpleEventPlugin: PluginModule & { topLevelType: TopLevelType, targetInst: null | Fiber, nativeEvent: MouseEvent, - nativeEventTarget: EventTarget, + nativeEventTarget: null | EventTarget, eventSystemFlags: EventSystemFlags, ): null | ReactSyntheticEvent { const dispatchConfig = topLevelEventsToDispatchConfig[topLevelType]; diff --git a/packages/react-native-renderer/src/ReactNativeBridgeEventPlugin.js b/packages/react-native-renderer/src/ReactNativeBridgeEventPlugin.js index 7cd42f07002e9..424f0eae25d22 100644 --- a/packages/react-native-renderer/src/ReactNativeBridgeEventPlugin.js +++ b/packages/react-native-renderer/src/ReactNativeBridgeEventPlugin.js @@ -35,7 +35,7 @@ const ReactNativeBridgeEventPlugin = { topLevelType: TopLevelType, targetInst: null | Object, nativeEvent: AnyNativeEvent, - nativeEventTarget: Object, + nativeEventTarget: null | Object, eventSystemFlags: EventSystemFlags, ): ?Object { if (targetInst == null) {