diff --git a/ContainerShip/scripts/run-android-ci-instrumentation-tests.js b/ContainerShip/scripts/run-android-ci-instrumentation-tests.js index e538be7a6a9318..a788bf19b80a26 100644 --- a/ContainerShip/scripts/run-android-ci-instrumentation-tests.js +++ b/ContainerShip/scripts/run-android-ci-instrumentation-tests.js @@ -38,7 +38,7 @@ const test_opts = { PATH: argv.path || './ReactAndroid/src/androidTest/java/com/facebook/react/tests', RETRIES: parseInt(argv.retries || 2, 10), - TEST_TIMEOUT: parseInt(argv['test-timeout'] || 1000 * 60 * 10), + TEST_TIMEOUT: parseInt(argv['test-timeout'] || 1000 * 60 * 10, 10), OFFSET: argv.offset, COUNT: argv.count, @@ -68,7 +68,6 @@ testClasses = testClasses.map((clazz) => { // only process subset of the tests at corresponding offset and count if args provided if (test_opts.COUNT != null && test_opts.OFFSET != null) { - const testCount = testClasses.length; const start = test_opts.COUNT * test_opts.OFFSET; const end = start + test_opts.COUNT; diff --git a/Libraries/Animated/src/bezier.js b/Libraries/Animated/src/bezier.js index d3ea74c27f56c6..5fffd867ea9ac1 100644 --- a/Libraries/Animated/src/bezier.js +++ b/Libraries/Animated/src/bezier.js @@ -82,7 +82,7 @@ module.exports = function bezier( mX2: number, mY2: number, ) { - if (!(0 <= mX1 && mX1 <= 1 && 0 <= mX2 && mX2 <= 1)) { + if (!(mX1 >= 0 && mX1 <= 1 && mX2 >= 0 && mX2 <= 1)) { throw new Error('bezier x values must be in [0, 1] range'); } diff --git a/Libraries/Animated/src/nodes/AnimatedValue.js b/Libraries/Animated/src/nodes/AnimatedValue.js index 7c4fe9817f98dd..e896f660000ab2 100644 --- a/Libraries/Animated/src/nodes/AnimatedValue.js +++ b/Libraries/Animated/src/nodes/AnimatedValue.js @@ -10,7 +10,6 @@ 'use strict'; const AnimatedInterpolation = require('./AnimatedInterpolation'); -const AnimatedNode = require('./AnimatedNode'); const AnimatedWithChildren = require('./AnimatedWithChildren'); const InteractionManager = require('InteractionManager'); const NativeAnimatedHelper = require('../NativeAnimatedHelper'); diff --git a/Libraries/Components/Keyboard/KeyboardAvoidingView.js b/Libraries/Components/Keyboard/KeyboardAvoidingView.js index 46e5c2e889e883..f8c620d9a495ae 100644 --- a/Libraries/Components/Keyboard/KeyboardAvoidingView.js +++ b/Libraries/Components/Keyboard/KeyboardAvoidingView.js @@ -150,7 +150,7 @@ class KeyboardAvoidingView extends React.Component { children, contentContainerStyle, enabled, - keyboardVerticalOffset, // eslint-disable-line no-unused-vars + keyboardVerticalOffset, style, ...props } = this.props; diff --git a/Libraries/Components/Touchable/TouchableOpacity.js b/Libraries/Components/Touchable/TouchableOpacity.js index 9d153a586a52d6..e5e1993c35cd36 100644 --- a/Libraries/Components/Touchable/TouchableOpacity.js +++ b/Libraries/Components/Touchable/TouchableOpacity.js @@ -247,7 +247,7 @@ const TouchableOpacity = ((createReactClass({ _getChildStyleOpacityWithDefault: function() { const childStyle = flattenStyle(this.props.style) || {}; - return childStyle.opacity == undefined ? 1 : childStyle.opacity; + return childStyle.opacity == null ? 1 : childStyle.opacity; }, render: function() { diff --git a/Libraries/Components/WebView/WebView.ios.js b/Libraries/Components/WebView/WebView.ios.js index f6c9295baba802..ba8034644d52a7 100644 --- a/Libraries/Components/WebView/WebView.ios.js +++ b/Libraries/Components/WebView/WebView.ios.js @@ -17,7 +17,6 @@ const Linking = require('Linking'); const PropTypes = require('prop-types'); const React = require('React'); const ReactNative = require('ReactNative'); -const ScrollView = require('ScrollView'); const StyleSheet = require('StyleSheet'); const Text = require('Text'); const UIManager = require('UIManager'); diff --git a/Libraries/Experimental/Incremental.js b/Libraries/Experimental/Incremental.js index b20fb543e947c5..a01bf9ae5c56f0 100644 --- a/Libraries/Experimental/Incremental.js +++ b/Libraries/Experimental/Incremental.js @@ -92,12 +92,11 @@ export type Props = { name: string, children: React.Node, }; -type DefaultProps = { - name: string, -}; + type State = { doIncrementalRender: boolean, }; + class Incremental extends React.Component { props: Props; state: State; diff --git a/Libraries/Experimental/SwipeableRow/SwipeableFlatList.js b/Libraries/Experimental/SwipeableRow/SwipeableFlatList.js index cf54d9d502f7f8..071ee6cdf6e3f5 100644 --- a/Libraries/Experimental/SwipeableRow/SwipeableFlatList.js +++ b/Libraries/Experimental/SwipeableRow/SwipeableFlatList.js @@ -12,7 +12,6 @@ import type {Props as FlatListProps} from 'FlatList'; import type {renderItemType} from 'VirtualizedList'; -const PropTypes = require('prop-types'); const React = require('React'); const SwipeableRow = require('SwipeableRow'); const FlatList = require('FlatList'); diff --git a/Libraries/Image/Image.android.js b/Libraries/Image/Image.android.js index 3eda5a7c52d2ec..2930ee90728081 100644 --- a/Libraries/Image/Image.android.js +++ b/Libraries/Image/Image.android.js @@ -17,7 +17,7 @@ const ImageViewNativeComponent = require('ImageViewNativeComponent'); const NativeModules = require('NativeModules'); const PropTypes = require('prop-types'); const React = require('React'); -const ReactNative = require('ReactNative'); +const ReactNative = require('ReactNative'); // eslint-disable-line no-unused-vars const StyleSheet = require('StyleSheet'); const TextAncestor = require('TextAncestor'); diff --git a/Libraries/Image/Image.ios.js b/Libraries/Image/Image.ios.js index 29532dea908e89..a20fd0a1206da6 100644 --- a/Libraries/Image/Image.ios.js +++ b/Libraries/Image/Image.ios.js @@ -12,7 +12,7 @@ const DeprecatedImagePropType = require('DeprecatedImagePropType'); const NativeModules = require('NativeModules'); const React = require('React'); -const ReactNative = require('ReactNative'); +const ReactNative = require('ReactNative'); // eslint-disable-line no-unused-vars const StyleSheet = require('StyleSheet'); const flattenStyle = require('flattenStyle'); diff --git a/Libraries/Lists/VirtualizedList.js b/Libraries/Lists/VirtualizedList.js index 37c574f0555530..89df0dab803a7a 100644 --- a/Libraries/Lists/VirtualizedList.js +++ b/Libraries/Lists/VirtualizedList.js @@ -643,7 +643,7 @@ class VirtualizedList extends React.PureComponent { } static getDerivedStateFromProps(newProps: Props, prevState: State) { - const {data, extraData, getItemCount, maxToRenderPerBatch} = newProps; + const {data, getItemCount, maxToRenderPerBatch} = newProps; // first and last could be stale (e.g. if a new, shorter items props is passed in), so we make // sure we're rendering a reasonable range here. return { diff --git a/Libraries/Modal/Modal.js b/Libraries/Modal/Modal.js index 28b55f91f1d2be..8e78b71c8750ff 100644 --- a/Libraries/Modal/Modal.js +++ b/Libraries/Modal/Modal.js @@ -20,7 +20,6 @@ const PropTypes = require('prop-types'); const StyleSheet = require('StyleSheet'); const View = require('View'); -const deprecatedPropType = require('deprecatedPropType'); const requireNativeComponent = require('requireNativeComponent'); const RCTModalHostView = requireNativeComponent('RCTModalHostView'); diff --git a/Libraries/ReactNative/UIManager.js b/Libraries/ReactNative/UIManager.js index ae48eaf2f0532a..4b03303b6386d3 100644 --- a/Libraries/ReactNative/UIManager.js +++ b/Libraries/ReactNative/UIManager.js @@ -147,7 +147,9 @@ if (Platform.OS === 'ios') { // we also tell Prepack that it has only partial knowledge of the UIManager, // so that any accesses to unknown properties along the global code will fail // when Prepack encounters them. - if (global.__makePartial) global.__makePartial(UIManager); + if (global.__makePartial) { + global.__makePartial(UIManager); + } } if (__DEV__) { diff --git a/Libraries/Utilities/setAndForwardRef.js b/Libraries/Utilities/setAndForwardRef.js index c135e73788f3a3..759569db41604c 100644 --- a/Libraries/Utilities/setAndForwardRef.js +++ b/Libraries/Utilities/setAndForwardRef.js @@ -10,8 +10,6 @@ 'use strict'; -const invariant = require('fbjs/lib/invariant'); - import type React from 'React'; type Args = $ReadOnly<{| diff --git a/Libraries/polyfills/babelHelpers.js b/Libraries/polyfills/babelHelpers.js index 47bc2440094200..605f6daaaa85d2 100644 --- a/Libraries/polyfills/babelHelpers.js +++ b/Libraries/polyfills/babelHelpers.js @@ -44,6 +44,8 @@ * @polyfill */ +/* eslint-disable no-func-assign, no-shadow, no-proto, no-void, no-undef-init */ + 'use strict'; var babelHelpers = (global.babelHelpers = {}); diff --git a/Libraries/polyfills/console.js b/Libraries/polyfills/console.js index 730a8c0ba57c2a..e8c4a7dbc3dca1 100644 --- a/Libraries/polyfills/console.js +++ b/Libraries/polyfills/console.js @@ -9,7 +9,7 @@ * @format */ -/* eslint-disable no-shadow, eqeqeq, curly, no-unused-vars, no-void */ +/* eslint-disable no-shadow, eqeqeq, curly, no-unused-vars, no-void, no-control-regex */ /** * This pipes all of our console logging functions to native logging so that diff --git a/RNTester/RNTesterUnitTests/RNTesterUnitTestsBundle.js b/RNTester/RNTesterUnitTests/RNTesterUnitTestsBundle.js index d55f9b975f9afa..20f4cc8caa1a78 100644 --- a/RNTester/RNTesterUnitTests/RNTesterUnitTestsBundle.js +++ b/RNTester/RNTesterUnitTests/RNTesterUnitTestsBundle.js @@ -9,8 +9,8 @@ 'use strict'; +// eslint-disable-next-line no-unused-vars const __fbBatchedBridge = { - // eslint-disable-line no-unused-vars flushedQueue: function() { return null; }, diff --git a/RNTester/e2e/sanity.test.js b/RNTester/e2e/sanity.test.js index 36bc0f577a60f3..366218c2e6d0ff 100644 --- a/RNTester/e2e/sanity.test.js +++ b/RNTester/e2e/sanity.test.js @@ -10,7 +10,7 @@ describe('Sanity', () => { beforeEach(async () => { await device.reloadReactNative(); - await element(by.label(`