From 018eac7d0328d9dc1ce964500c80eaf8f75da8f3 Mon Sep 17 00:00:00 2001 From: John Shelley Date: Tue, 6 Dec 2016 14:47:03 -0600 Subject: [PATCH 1/2] Allow getUseDeveloperSupport to be public --- .../src/main/java/com/facebook/react/ReactNativeHost.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/ReactNativeHost.java b/ReactAndroid/src/main/java/com/facebook/react/ReactNativeHost.java index 2e341460c3a576..57d7b45fc74ff9 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/ReactNativeHost.java +++ b/ReactAndroid/src/main/java/com/facebook/react/ReactNativeHost.java @@ -138,7 +138,7 @@ protected String getJSMainModuleName() { /** * Returns whether dev mode should be enabled. This enables e.g. the dev menu. */ - protected abstract boolean getUseDeveloperSupport(); + public abstract boolean getUseDeveloperSupport(); /** * Returns a list of {@link ReactPackage} used by the app. From 7cd11e2c4f7166bc2a90bfffa31f0848d7fce819 Mon Sep 17 00:00:00 2001 From: John Shelley Date: Tue, 6 Dec 2016 19:35:16 -0600 Subject: [PATCH 2/2] update implementing methods --- .../main/java/com/facebook/react/movies/MoviesApplication.java | 2 +- .../java/com/facebook/react/tictactoe/TicTacToeApplication.java | 2 +- .../app/src/main/java/com/helloworld/MainApplication.java | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Examples/Movies/android/app/src/main/java/com/facebook/react/movies/MoviesApplication.java b/Examples/Movies/android/app/src/main/java/com/facebook/react/movies/MoviesApplication.java index a620b3eb699416..ee57b9b595fc58 100644 --- a/Examples/Movies/android/app/src/main/java/com/facebook/react/movies/MoviesApplication.java +++ b/Examples/Movies/android/app/src/main/java/com/facebook/react/movies/MoviesApplication.java @@ -39,7 +39,7 @@ public String getJSMainModuleName() { } @Override - protected boolean getUseDeveloperSupport() { + public boolean getUseDeveloperSupport() { return true; } diff --git a/Examples/TicTacToe/android/app/src/main/java/com/facebook/react/tictactoe/TicTacToeApplication.java b/Examples/TicTacToe/android/app/src/main/java/com/facebook/react/tictactoe/TicTacToeApplication.java index bf56be8f4df18f..c765a847cf39cd 100644 --- a/Examples/TicTacToe/android/app/src/main/java/com/facebook/react/tictactoe/TicTacToeApplication.java +++ b/Examples/TicTacToe/android/app/src/main/java/com/facebook/react/tictactoe/TicTacToeApplication.java @@ -39,7 +39,7 @@ public String getJSMainModuleName() { } @Override - protected boolean getUseDeveloperSupport() { + public boolean getUseDeveloperSupport() { return true; } diff --git a/local-cli/templates/HelloWorld/android/app/src/main/java/com/helloworld/MainApplication.java b/local-cli/templates/HelloWorld/android/app/src/main/java/com/helloworld/MainApplication.java index ed63744b72a0b2..89bc02c760e370 100644 --- a/local-cli/templates/HelloWorld/android/app/src/main/java/com/helloworld/MainApplication.java +++ b/local-cli/templates/HelloWorld/android/app/src/main/java/com/helloworld/MainApplication.java @@ -17,7 +17,7 @@ public class MainApplication extends Application implements ReactApplication { private final ReactNativeHost mReactNativeHost = new ReactNativeHost(this) { @Override - protected boolean getUseDeveloperSupport() { + public boolean getUseDeveloperSupport() { return BuildConfig.DEBUG; }