Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooling: webhooks to add labels to PRs #855

Closed
ide opened this issue Apr 15, 2015 · 2 comments
Closed

Tooling: webhooks to add labels to PRs #855

ide opened this issue Apr 15, 2015 · 2 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@ide
Copy link
Contributor

ide commented Apr 15, 2015

From brief chat w @vjeux we want to improve the code review workflow using labels. The labels will show the state of each PR and help contributors and reviewers be on the same page wrt the next step for each PR. I imagine the flow to mostly look like:

  1. Contributor submits PR. Label: [needs-review]
  2. Reviewer imports PR into Differential
  3. Reviewer has some questions but no requests for changes yet, submits comments
  4. Contributor responds to questions
  5. Reviewer posts new comments asking for changes (can Differential ping a webhook when this happens?) Label: [needs-revision]
  6. Contributor updates PR by updating their branch. Label: [needs-review]
  7. Reviewer accepts the diff and lands it through Differential
  8. Bot automatically creates a corresponding Git commit and pushes it to GitHub. Bot removes the label from the PR and closes it.

(@vjeux are there parts that are different that from what you have in mind?)

@vjeux
Copy link
Contributor

vjeux commented Apr 15, 2015

Actually i would skip the differential part of the process. We should review it without knowing the fb-side of things and when it's accepted then only at this point do the phabricator import. I want to move towards a world where tests in open source are the "source of truth" and if something breaks internally we need to add a test in open source. This will make going github first easier when we do it.

  1. Contributor submits a PR. [Needs Review] <--- bot
  2. Reviewer manually tags it as [Needs Revision]
  3. Contributor updates the PR. [Needs Review] <--- bot
  4. Reviewer manually tags it as [Accepted]
  5. Reviewer imports it, get it accepted inside of fb, lands it...

So, for this task, the only thing that needs to be done is whenever a pull request is updated, need to remove the review tag and replace it with [Needs Review](except if it's already been accepted)

@ide
Copy link
Contributor Author

ide commented Apr 15, 2015

Makes sense, thanks for the clarification.

@facebook facebook locked as resolved and limited conversation to collaborators May 29, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

4 participants