-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nested stateless components do not hot reload #8465
Comments
cc @martinbigio |
Have same issue
|
I don't even need to nest the components.
|
I think the trick is to have at least one ES6 component. Then it should work. |
@steida could you elaborate you comment? |
@steida thanks. I tried but it doesn't work, i'm using react native ver 0.31 |
It works in Este, so get an inspiration from it. |
Same issue on 0.33, stateless functional component doesn't hot reload, works with ES6 class syntax.
|
This still happens for me too. in 0.34.1 |
Any fix on the horizon? Been using hot reloadable stateless components in React vanilla for some time now, and wouldn't want to switch back to stateful components if there is no actual need. |
Same issue on 0.35.0, iOS simulator and device, Mac. |
Still an issue. 0.37.0 with iOS simulator on mac. |
+1 under v0.37 |
+1 on 0.40 |
+1 |
Bump! +1 on v0.40 |
Will this issue be resolved anytime in the near future? |
+1! still existing on 0.44.0 |
If you're still running into this, the best approach right now would be to send a PR with a fix. Please refrain from adding metoo comments so that we can keep the discussion focused on a fix. |
Try my babel plugin https://github.com/bvic23/babel-plugin-functional-hmr until the issue is fixed. |
Hi there! This issue is being closed because it has been inactive for a while. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. Either way, we're automatically closing issues after a period of inactivity. Please do not take it personally! If you think this issue should definitely remain open, please let us know. The following information is helpful when it comes to determining if the issue should be re-opened:
If you would like to work on a patch to fix the issue, contributions are very welcome! Read through the contribution guide, and feel free to hop into #react-native if you need help planning your contribution. |
This has been fixed on master and should get into 0.61. #18899 (comment) If you have more cases that don't work please post reproducing examples in #18899. |
(The only caveat is that for Fast Refresh to work, you'll need to move your root component to a separate file) |
Stateless components:
Same but with a class:
0.28.0
both
Mac
The text was updated successfully, but these errors were encountered: