You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a mostly straightforward task but may need some changes from Facebook's side if there is existing code calling into -[initWithJavaScriptThread:globalContextRef:]. The only tricky thing I see is the check in dealloc to see if the current thread is the JS thread. That could be replaced with dispatch_queue_set_specific and dispatch_get_specific, or dealloc could simply always dispatch_async. I'm also not sure it's needed at all since JSC should be thread-safe.
The text was updated successfully, but these errors were encountered:
This is a mostly straightforward task but may need some changes from Facebook's side if there is existing code calling into
-[initWithJavaScriptThread:globalContextRef:]
. The only tricky thing I see is the check indealloc
to see if the current thread is the JS thread. That could be replaced withdispatch_queue_set_specific
anddispatch_get_specific
, or dealloc could simply always dispatch_async. I'm also not sure it's needed at all since JSC should be thread-safe.The text was updated successfully, but these errors were encountered: