Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inspector Tools issue when view are transformed in Fabric #45502

Closed
realsoelynn opened this issue Jul 17, 2024 · 0 comments
Closed

Inspector Tools issue when view are transformed in Fabric #45502

realsoelynn opened this issue Jul 17, 2024 · 0 comments
Labels
Help Wanted :octocat: Issues ideal for external contributors. Resolution: Fixed A PR that fixes this issue has been merged. Type: New Architecture Issues and PRs related to new architecture (Fabric/Turbo Modules)

Comments

@realsoelynn
Copy link
Contributor

Description

When Views are transformed (as seen in the example with Vertical Inversion) and try to inspect element, wrong elements is being inspected because findNodeAtPoint in Fabric is not accounting for transform.

This is happening in both iOS and Android

Steps to reproduce

  1. Run iOS project with Fabric RCT_NEW_ARCH_ENABLED=1 pod install
  2. Press Cmd + Ctrl + Z to open Developer Menu
  3. Select Toggle Element Inspector
  4. Try to select Item 1

Expected:
Item 1 should be highlighted

Actual:
Item 3 is hightlighted

React Native Version

Any Version that has Fabric

Affected Platforms

Runtime - Android, Runtime - iOS

Areas

Fabric - The New Renderer

Output of npx react-native info

> ReproducerApp@0.0.1 npx
> react-native info

info Fetching system and libraries information...
System:
  OS: macOS 14.5
  CPU: (16) arm64 Apple M3 Max
  Memory: 7.91 GB / 128.00 GB
  Shell:
    version: "5.9"
    path: /bin/zsh
Binaries:
  Node:
    version: 20.12.2
    path: ~/.nvm/versions/node/v20.12.2/bin/node
  Yarn:
    version: 3.6.4
    path: ~/.nvm/versions/node/v20.12.2/bin/yarn
  npm:
    version: 10.6.0
    path: ~/.nvm/versions/node/v20.12.2/bin/npm
  Watchman:
    version: 2024-07-14T04:03:59Z
    path: /usr/local/bin/watchman
Managers:
  CocoaPods:
    version: 1.15.2
    path: /opt/homebrew/bin/pod
SDKs:
  iOS SDK:
    Platforms:
      - DriverKit 23.5
      - iOS 17.5
      - macOS 14.5
      - tvOS 17.5
      - visionOS 1.2
      - watchOS 10.5
  Android SDK:
    API Levels:
      - "26"
      - "27"
      - "28"
      - "29"
      - "30"
      - "31"
      - "33"
      - "34"
    Build Tools:
      - 33.0.1
      - 34.0.0
    System Images:
      - android-26 | Google APIs ARM 64 v8a
      - android-34 | Google APIs ARM 64 v8a
    Android NDK: Not Found
IDEs:
  Android Studio: 2023.1 AI-231.9392.1.2311.11330709
  Xcode:
    version: 15.4/15F31c
    path: /usr/bin/xcodebuild
Languages:
  Java:
    version: 11.0.22
    path: /Users/soelynn/.sdkman/candidates/java/current/bin/javac
  Ruby:
    version: 2.6.10
    path: /usr/bin/ruby
npmPackages:
  "@react-native-community/cli": Not Found
  react:
    installed: 18.2.0
    wanted: 18.2.0
  react-native:
    installed: 0.74.3
    wanted: 0.74.3
  react-native-macos: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: true
  newArchEnabled: false
iOS:
  hermesEnabled: true
  newArchEnabled: true

Stacktrace or Logs

N/A

Reproducer

https://github.com/realsoelynn/rn-inspectortools-transform-related-reproducer

Screenshots and Videos

Inspector-ParentView.Transform.Issue.mov
@realsoelynn realsoelynn added Help Wanted :octocat: Issues ideal for external contributors. Type: New Architecture Issues and PRs related to new architecture (Fabric/Turbo Modules) labels Jul 17, 2024
@zhongwuzw zhongwuzw mentioned this issue Jul 18, 2024
Closed
@coado coado mentioned this issue Jul 22, 2024
Draft
@cortinico cortinico added the Resolution: Fixed A PR that fixes this issue has been merged. label Aug 16, 2024
@coado coado mentioned this issue Aug 19, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Help Wanted :octocat: Issues ideal for external contributors. Resolution: Fixed A PR that fixes this issue has been merged. Type: New Architecture Issues and PRs related to new architecture (Fabric/Turbo Modules)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fabric] Fixes findNodeAtPoint when views were inverted zhongwuzw/react-native
2 participants
@cortinico @realsoelynn