Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add headers in fabric image component #45415

Closed
wants to merge 2 commits into from
Closed

fix: add headers in fabric image component #45415

wants to merge 2 commits into from

Conversation

deepanshushuklad11
Copy link
Contributor

@deepanshushuklad11 deepanshushuklad11 commented Jul 12, 2024 •
edited
Loading

FIXES 45404

Summary:

sending headers from Image component not working in new arch , implementation was missing
<Image source={{ uri: "http://localhost:3000/image", headers: { "test-header": 'test', "hello":"tested" } }} style={{ width: 300, height: 300, }} />

Changelog:

[IOS] [ADDED]- sending missing headers field with Image component in fabric

Test Plan:

Tested
Attaching the below video to show how headers are getting received on server from Image component running in new arch

Screen.Recording.2024-07-12.at.8.15.37.PM.1.1.mov

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Jul 12, 2024
@deepanshushuklad11 deepanshushuklad11 changed the title fix: add image header in fabric image component fix: add headers in fabric image component Jul 12, 2024
@deepanshushuklad11
Copy link
Contributor Author

@cipolleschi Checks are failing . I am not sure why.
Can you help ?

@blakef
Copy link
Contributor

blakef commented Jul 15, 2024

@deepanshushuklad11 main is currently not stable. Once it stabilises, rebase off that commit.

@cipolleschi Checks are failing . I am not sure why. Can you help ?

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 21,383,875 +32,769
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 24,580,606 +32,750
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: d2773f0
Branch: main

@deepanshushuklad11
Copy link
Contributor Author

@deepanshushuklad11 main is currently not stable. Once it stabilises, rebase off that commit.

@cipolleschi Checks are failing . I am not sure why. Can you help ?

Thanks @blakef
All checks have passed now

@facebook-github-bot
Copy link
Contributor

@blakef has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jul 16, 2024
@facebook-github-bot
Copy link
Contributor

@blakef merged this pull request in 50f7892.

@github-actions GitHub Actions
Copy link

This pull request was successfully merged by @deepanshushuklad11 in 50f7892

When will my fix make it into a release? | How to file a pick request?

@shubhamguptadream11 shubhamguptadream11 mentioned this pull request Oct 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

headers defined in Image source prop are not sent along with the request for a remote image
4 participants
@deepanshushuklad11 @blakef @analysis-bot @facebook-github-bot