Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate Environment Scripts #19694

Closed
hramos opened this issue Jun 13, 2018 · 7 comments
Closed

Validate Environment Scripts #19694

hramos opened this issue Jun 13, 2018 · 7 comments
Labels
DX Issues concerning how the developer experience can be improved. Good first issue Interested in collaborating? Take a stab at fixing one of these issues. Help Wanted :octocat: Issues ideal for external contributors. Platform: iOS iOS applications. Resolution: Locked This issue was locked by the bot. Type: Discussion Long running discussion.

Comments

@hramos
Copy link
Contributor

hramos commented Jun 13, 2018

For Discussion

Looking for contributors interested in making the React Native experience better for everyone. We currently have a script in the repo, scripts/validate-android-test-env.sh, that will raise any issues with your local Android environment, such as a missing AVD configuration, or a lack of a proper Android SDK.

We do not have an equivalent for iOS development environments. A script could be used to:

  • Validate the minimum required Xcode version is installed (people using Xcode 8 with a recent release may encounter cryptic build errors)
  • Validate the correct Node version is installed (Node 10 is not fully supported at the time, Node 6 is no longer supported)

Furthermore, these scripts (iOS, Android) could be invoked as part of the react-native CLI (if needed) in order to surface any issues as early as possible.

Please tag me in any PRs!

@hramos hramos added Good first issue Interested in collaborating? Take a stab at fixing one of these issues. Platform: iOS iOS applications. Help Wanted :octocat: Issues ideal for external contributors. 💻CLI DX Issues concerning how the developer experience can be improved. labels Jun 13, 2018
@react-native-bot react-native-bot added the Type: Discussion Long running discussion. label Jun 13, 2018
@vaibhavsingh97
Copy link

@hramos I would love to solve this issue, but I had never worked with iOS. Can you please guide me what are essential things I should take care while writing one such script 😄

@hgale
Copy link

hgale commented Jun 16, 2018

@hramos please excuse my rusty bash but this should work.

@hgale
Copy link

hgale commented Jun 18, 2018

@hramos just following up on this:

"Furthermore, these scripts (iOS, Android) could be invoked as part of the react-native CLI (if needed) in order to surface any issues as early as possible."

Any examples of how you would like me to do this? Also apart from running the script locally, is there anything else I can do to validate that it works as you expect? Thanks.

@hramos
Copy link
Contributor Author

hramos commented Aug 2, 2018

Re-opening, 1fb7a25 added a script to validate iOS but I still need to follow up to Harry's question.

@hramos hramos reopened this Aug 2, 2018
@simistern
Copy link

Is this issue closed? I would like to help out if possible.

@justinemignot
Copy link

@hramos Hi, I would like to help about adding these scripts as part of the react-native CLI. Do you still think it is relevant to do this ? And is there someone already working on this issue ?
Thank you for your time. Justine

@hramos
Copy link
Contributor Author

hramos commented Dec 13, 2018

The CLI has been moved out of the repo. Do you want to create a new issue in https://github.com/react-native-community/react-native-cli to discuss how this might be implemented in the new package?

@hramos hramos closed this as completed Dec 13, 2018
@facebook facebook locked as resolved and limited conversation to collaborators Dec 13, 2019
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Dec 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
DX Issues concerning how the developer experience can be improved. Good first issue Interested in collaborating? Take a stab at fixing one of these issues. Help Wanted :octocat: Issues ideal for external contributors. Platform: iOS iOS applications. Resolution: Locked This issue was locked by the bot. Type: Discussion Long running discussion.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants