Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-native-cli link infinite android link #18053

Closed
loic-lopez opened this issue Feb 22, 2018 · 7 comments
Closed

react-native-cli link infinite android link #18053

loic-lopez opened this issue Feb 22, 2018 · 7 comments
Labels
Platform: Android Android applications. Ran Commands One of our bots successfully processed a command. Stale There has been a lack of activity on this issue and it may be closed soon.

Comments

@loic-lopez
Copy link

Is this a bug report?

Yes :
I have updated my package.json to react-native 0.53 and now my android depencencies are not linking once.

Environment

Environment:
OS: macOS High Sierra 10.13.3
Node: 9.5.0
Yarn: Not Found
npm: 5.6.0
Watchman: Not Found
Xcode: Xcode 9.2 Build version 9C40b
Android Studio: 3.0 AI-171.4443003

Packages: (wanted => installed)
react: ^16.2.0 => 16.2.0
react-native: 0.53.3 => 0.53.3

Target Platform: iOS (10.3)

Steps to Reproduce

  1. upgrade react-native
    2.npm install
    3.react-native link

Reproducible Demo

You can view my Stack Overflow post :
infinite-react-native-link-with-android-dependencies

@Shamash2014
Copy link

Confirmed. The same with react version 16.3.0

@oyyq99999
Copy link

Same issue here.
react-native link works properly with react-native versions 0.52.0 and 0.53.0, but create duplicated imports/settings for android with react-native versions 0.52.* or 0.53.* where * is greater than 0

@react-native-bot react-native-bot added Android Ran Commands One of our bots successfully processed a command. labels Mar 18, 2018
@react-native-bot react-native-bot added Platform: Android Android applications. Ran Commands One of our bots successfully processed a command. labels Mar 18, 2018
@loic-lopez
Copy link
Author

Hi again,

In which react-native version the fix was deployed?

@stale
Copy link

stale bot commented Jun 30, 2018

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as "For Discussion" or "Good first issue" and I will leave it open. Thank you for your contributions.

@stale stale bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Jun 30, 2018
@Shamash2014
Copy link

It's fixed in react native version 0.56 and 0.55

@stale stale bot removed the Stale There has been a lack of activity on this issue and it may be closed soon. label Jun 30, 2018
@stale
Copy link

stale bot commented Sep 28, 2018

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as "For Discussion" or "Good first issue" and I will leave it open. Thank you for your contributions.

@stale stale bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Sep 28, 2018
@stale
Copy link

stale bot commented Oct 5, 2018

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please feel free to create a new issue with up-to-date information.

@stale stale bot closed this as completed Oct 5, 2018
@facebook facebook locked as resolved and limited conversation to collaborators Oct 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Platform: Android Android applications. Ran Commands One of our bots successfully processed a command. Stale There has been a lack of activity on this issue and it may be closed soon.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants