Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Navigator] _popN does not update routeStack state #1727

Closed
kyle-ssg opened this issue Jun 23, 2015 · 4 comments
Closed

[Navigator] _popN does not update routeStack state #1727

kyle-ssg opened this issue Jun 23, 2015 · 4 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@kyle-ssg
Copy link

The navigator keeps the routestack in state, this seems to be used by getCurrentRoutes. I noticed this gets updated on push but not pop/popN.

I'd expect a state update similar to the following:
this.setState({
idStack: nextIDStack,
routeStack: nextStack,
sceneConfigStack: nextAnimationConfigStack,
updatingRangeStart: nextStack.length - 1,
updatingRangeLength: 1,
});

@chirag04
Copy link
Contributor

@ericvicenti can help here. Can be a serious bug for performance.

@chirag04
Copy link
Contributor

I just did a small test can't get to replicate this though. Mind sharing a fiddle on rnplay?

@brentvatne brentvatne changed the title Navigator _popN does not update routeStack state [Navigator] _popN does not update routeStack state Jun 23, 2015
@ericvicenti ericvicenti self-assigned this Jun 23, 2015
@ericvicenti
Copy link
Contributor

Agreed- a simplified example on RNPlay would be great to see

Currently, (and I agree that it's not ideal,) the Navigator will only remove the popped routes once the pop animation completes.

@brentvatne
Copy link
Collaborator

New Navigator is in progress, you can comment on it here: https://github.com/ericvicenti/navigation-rfc

@facebook facebook locked as resolved and limited conversation to collaborators Jul 22, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

5 participants