Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll Text in tvOS #14852

Closed
skyAnja opened this issue Jul 6, 2017 · 6 comments
Closed

Scroll Text in tvOS #14852

skyAnja opened this issue Jul 6, 2017 · 6 comments
Labels
Stale There has been a lack of activity on this issue and it may be closed soon.

Comments

@skyAnja
Copy link

skyAnja commented Jul 6, 2017

Is this a bug report?

Yes

Have you read the Bugs section of the Contributing to React Native Guide?

Yes

Environment

react-native-cli: 2.0.1
react-native: 0.43.2
node: v6.10.3
npm: 3.10.10
yarn: 0.23.4

  1. Target Platform: tvOS
  2. Development Operating System: macOS Sierra 10.12.5
  3. Build tools: XCode Version 8.3.3 (8E3004b)

Steps to Reproduce

Text that is vertically too large to fit on a screen. No possibility to scroll this text

Expected Behavior

If the Text or TouchableHighlight or ScrollView gets focus, the remote keys for 'up' and 'down' should scroll the View and make text below readable

Actual Behavior

Nothing happens. If there is an element below, this gets focus. Also doesn't work if there is no element above or below

Tested Possibilities

  • Every Combination of nesting Text or TouchableHighlight or ScrollView or FlatList
  • Give every element a fixed height

Working native solution

descriptionTextView.UserInteractionEnabled = true; descriptionTextView.ScrollEnabled = true; descriptionTextView.PanGestureRecognizer.AllowedTouchTypes = new NSNumber[]{(int)UITouchType.Indirect}; descriptionTextView.ShowsVerticalScrollIndicator = true;

@JulienKode
Copy link
Contributor

JulienKode commented Jul 23, 2017

I have the same problem, so I've created a custom bridged component, if you need some help just tell me

I think we need to improve a lot of things to have a better experience on react-native tvOS

@douglowder
Copy link
Contributor

Thanks for the bug report -- I'll take a look at this issue.

@douglowder
Copy link
Contributor

@JulienKode @skyAnja please see https://github.com/dlowder-salesforce/react-native/tree/tvos-scrollview-focus for a possible fix. Includes additions to the RNTester ScrollView example.

@JulienKode
Copy link
Contributor

@dlowder-salesforce perfect solution 👍

@stale
Copy link

stale bot commented Oct 23, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. If you think this issue should definitely remain open, please let us know why. Thank you for your contributions.

@stale stale bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Oct 23, 2017
@stale stale bot closed this as completed Oct 30, 2017
@gtebbutt
Copy link
Contributor

@dlowder-salesforce that does indeed look like a perfect solution! Is there any plan to get this merged in?

@facebook facebook locked and limited conversation to collaborators May 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Stale There has been a lack of activity on this issue and it may be closed soon.
Projects
None yet
Development

No branches or pull requests

4 participants