Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] app hang when include CJK characters multiline TextInput #14628

Closed
yangyi opened this issue Jun 20, 2017 · 1 comment
Closed

[iOS] app hang when include CJK characters multiline TextInput #14628

yangyi opened this issue Jun 20, 2017 · 1 comment
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@yangyi
Copy link

yangyi commented Jun 20, 2017

Description

when using CJK chars in multiline TextInput, app hangs, and unresponsive.

Reproduction Steps

paste sample code in any page of your app, and navigate to the page

Sample Code

export default class App extends React.Component {
  render() {
    const text = <Text>王者荣耀</Text>
    return (
      <View style={styles.container}>
        <TextInput multiline>
          {text}
        </TextInput>
      </View>
    );
  }

I also provide an git repo https://github.com/yangyi/demoinput

Solution

I replace NaN with CGFLOAT_MAX, that resolve the issue, but I'm not sure why this happens, and the solution is not well tested.

the commit is here

yangyi@aadebd7

Additional Information

  • React Native version: v0.45.1
  • Platform: iOS
  • Development Operating System: macOS
  • Build tools: XCode Version 8.3.2 (8E2002)
@hramos hramos added the Icebox label Aug 24, 2017
@hramos
Copy link
Contributor

hramos commented Aug 24, 2017

Hi there! This issue is being closed because it has been inactive for a while. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. Either way, we're automatically closing issues after a period of inactivity. Please do not take it personally!

If you think this issue should definitely remain open, please let us know. The following information is helpful when it comes to determining if the issue should be re-opened:

  • Does the issue still reproduce on the latest release candidate? Post a comment with the version you tested.
  • If so, is there any information missing from the bug report? Post a comment with all the information required by the issue template.
  • Is there a pull request that addresses this issue? Post a comment with the PR number so we can follow up.

If you would like to work on a patch to fix the issue, contributions are very welcome! Read through the contribution guide, and feel free to hop into #react-native if you need help planning your contribution.

@hramos hramos closed this as completed Aug 24, 2017
@facebook facebook locked as resolved and limited conversation to collaborators Aug 24, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Aug 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

3 participants