Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Overwriting "multipart/mixed" content-type if set explicitely #14597

Closed
stinodes opened this issue Jun 19, 2017 · 1 comment
Closed

[iOS] Overwriting "multipart/mixed" content-type if set explicitely #14597

stinodes opened this issue Jun 19, 2017 · 1 comment
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@stinodes
Copy link

Description

I am trying to send a multipart/mixed request, uploading a picture and message to a back-end.
Setting the header Content-Type: multipart/mixed works as expected on Android and adds the boundary. On iOS, it defaults to multipart/form-data.

Seems to be a bug, unless there are iOS limitations I am not aware of.

Reproduction Steps

Start a request from javascript, set a FormData-instance as body and set the Content-Type header to multipart/mixed.

Sample Code

https://snack.expo.io/B1cRI7rQZ
(Will always produce an error, due to a lack of a public endpoint to fire the request to. Might be able to intercept event somehow.)

Solution

In /Libraries/Network/RCTNetworking.mm, conditionally use the Content-Type header passed from the javascript request at line: 120.

Additional Information

  • React Native version: 0.44.0
  • Platform: iOS
  • Development Operating System: OS X 10.12.3 (16D32)
  • Build tools: XCode Version 8.3.2 (8E2002), iOS 9.3.5, React Native packager
@stinodes stinodes changed the title Multipart content-type header not checked on iOS [iOS] Overwriting "multipart/mixed" content-type if set explicitely Jun 20, 2017
@hramos hramos added the Icebox label Aug 24, 2017
@hramos
Copy link
Contributor

hramos commented Aug 24, 2017

Hi there! This issue is being closed because it has been inactive for a while. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. Either way, we're automatically closing issues after a period of inactivity. Please do not take it personally!

If you think this issue should definitely remain open, please let us know. The following information is helpful when it comes to determining if the issue should be re-opened:

  • Does the issue still reproduce on the latest release candidate? Post a comment with the version you tested.
  • If so, is there any information missing from the bug report? Post a comment with all the information required by the issue template.
  • Is there a pull request that addresses this issue? Post a comment with the PR number so we can follow up.

If you would like to work on a patch to fix the issue, contributions are very welcome! Read through the contribution guide, and feel free to hop into #react-native if you need help planning your contribution.

@hramos hramos closed this as completed Aug 24, 2017
@facebook facebook locked as resolved and limited conversation to collaborators Aug 24, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Aug 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

3 participants