Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation not clear on support for Fragments - Please clarify support for Fragments #13852

Closed
dobrienlzd opened this issue May 9, 2017 · 5 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@dobrienlzd
Copy link

dobrienlzd commented May 9, 2017

The existence of a FragmentActivity would suggest support for Fragments. However, it seems that Fragments are not actually supported by React Native. They do not exist at all in any sample code. (Prove me wrong!). There is an outstanding issue to integrate a ReactFragment class. There are issues in handling on touch events inside a fragment that is based on react. Is there someone who can clarify the situation? What is the best option for those that want to use react native inside a fragment vs. activity? In particular to have an activity with some fragments that are native and one or more fragments that is react native. I need clarification if this can be done. This question obviously needs answering for anyone who is planning on a hybrid approach with the UI like integrating into an existing Android app.

@githubdoramon
Copy link

Having this problem here too... And it is a stopper to use react native as an hybrid solution, since I have a native view pager on my main activity, and am trying to have one os the fragments with react native

@aditijoshi
Copy link

+1

@githubdoramon
Copy link

I guess we will never get a reply for this :(

@dobrienlzd
Copy link
Author

@githubdoramon @aditijoshi It's taking a while. Looks like there is some movement on #12199 to release some sample code for at least one approach to doing this.

@hramos
Copy link
Contributor

hramos commented Jul 20, 2017

Hi there! This issue is being closed because it has been inactive for a while. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. Either way, we're automatically closing issues after a period of inactivity. Please do not take it personally!

If you think this issue should definitely remain open, please let us know. The following information is helpful when it comes to determining if the issue should be re-opened:

  • Does the issue still reproduce on the latest release candidate? Post a comment with the version you tested.
  • If so, is there any information missing from the bug report? Post a comment with all the information required by the issue template.
  • Is there a pull request that addresses this issue? Post a comment with the PR number so we can follow up.

If you would like to work on a patch to fix the issue, contributions are very welcome! Read through the contribution guide, and feel free to hop into #react-native if you need help planning your contribution.

@hramos hramos added the Icebox label Jul 20, 2017
@hramos hramos closed this as completed Jul 20, 2017
@facebook facebook locked as resolved and limited conversation to collaborators Jul 20, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

5 participants