Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open source pull-to-refresh component #121

Closed
ide opened this issue Mar 4, 2015 · 8 comments
Closed

Open source pull-to-refresh component #121

ide opened this issue Mar 4, 2015 · 8 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@ide
Copy link
Contributor

ide commented Mar 4, 2015

Another one of those staples on mobile. It would be ideal to be able to compose it with ListViews, ScrollViews, etc.

@milanvanschaik
Copy link

+1 I would love to see support for horizontal ScrollViews as well.

@vjeux
Copy link
Contributor

vjeux commented Mar 5, 2015

Horizontal scroll view is already supported. horizontal={true}

For pull to refresh, it's actually quite easy to build. we haven't yet figured out how many components we want to provide, so it's up in the air if this one is going to be provided by us vs the community

@ide
Copy link
Contributor Author

ide commented Mar 6, 2015

@vjeux Most of the Apple components are useful to have because they have a lot of subtle details that take work to get right so it's helpful to have some robust implementations:

  • Pull-to-refresh spinner: animate based on the scroll position, "snap" to provide visual feedback when the refresh action begins
  • Table view: cell animation, separator placement
  • Navigation controller: nav bar interpolation, animating in new screens on-demand
  • Collection view: this is hard to build but supports a lot of layouts and animations

@milanvanschaik
Copy link

@vjeux Sorry, I meant the pull-to-refresh to have support for horizontal scrollviews. The default one from Apple doesn't have that support.

@ide
Copy link
Contributor Author

ide commented Mar 18, 2015

@vjeux Could we get an update on the pull-to-refresh component? Beyond being a really common UI element I believe the gesture-based animation that you described in #46 requires some thought to build, and it probably makes sense for 3rd party components to share a style interpolation technique.

@vjeux
Copy link
Contributor

vjeux commented Mar 18, 2015

Nothing planed on our end sorry :( Already have a ton of work to expose all the components we have internally. Hopefully you or someone from the community can pick it up and put it on npm. If it's good quality we may want to embed it into core down the line

@ide
Copy link
Contributor Author

ide commented Mar 19, 2015

@vjeux sounds reasonable. could you throw the style interpolation code over the wall as a starting point?

@ide
Copy link
Contributor Author

ide commented May 27, 2015

There's enough of a foundation now that this can be built independently.

@ide ide closed this as completed May 27, 2015
@facebook facebook locked as resolved and limited conversation to collaborators May 29, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

4 participants