Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

namedOrientationDidChange not supported on iOS #11429

Closed
TLenahan opened this issue Dec 12, 2016 · 3 comments
Closed

namedOrientationDidChange not supported on iOS #11429

TLenahan opened this issue Dec 12, 2016 · 3 comments
Labels
Platform: iOS iOS applications. Resolution: Locked This issue was locked by the bot.

Comments

@TLenahan
Copy link

Description

Currently there is no implementation of the namedOrientationDidChange event for iOS. There is also an issue with Dimensions not correctly updating on rotation which there is a Pull Request out for. I am looking to be able to subscribe to the namedOrientationDidChange event on both platforms.

Reproduction

Although I am unable to rotate the Simulator/Emulator on RNPlay, i have created an example app to demonstrate how I am using the namedOrientationDidChange event.
https://rnplay.org/apps/T7yq6A

Solution

Will namedOrientationDidChange be implemented on the iOS side? Or is it suggested to use a third party library. I would prefer to not rely on a third party library if RN can provide a solution.

Additional Information

  • React Native version: 0.39.0
  • Platform: iOS
  • Operating System: MacOS
@mroswald
Copy link
Contributor

Are there any news on that? Did you check https://github.com/yamill/react-native-orientation ?

@shergin shergin added the Platform: iOS iOS applications. label Mar 16, 2017
@idibidiart
Copy link

idibidiart commented Apr 25, 2017

automatic re-layout is not always enough, we need a way to tell when orientation has changed (I'm using Expo so I can't use native libraries)

@hramos
Copy link
Contributor

hramos commented Jul 20, 2017

Hi there! This issue is being closed because it has been inactive for a while. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. Either way, we're automatically closing issues after a period of inactivity. Please do not take it personally!

If you think this issue should definitely remain open, please let us know. The following information is helpful when it comes to determining if the issue should be re-opened:

  • Does the issue still reproduce on the latest release candidate? Post a comment with the version you tested.
  • If so, is there any information missing from the bug report? Post a comment with all the information required by the issue template.
  • Is there a pull request that addresses this issue? Post a comment with the PR number so we can follow up.

If you would like to work on a patch to fix the issue, contributions are very welcome! Read through the contribution guide, and feel free to hop into #react-native if you need help planning your contribution.

@hramos hramos added the Icebox label Jul 20, 2017
@hramos hramos closed this as completed Jul 20, 2017
@facebook facebook locked as resolved and limited conversation to collaborators Jul 20, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Platform: iOS iOS applications. Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

6 participants