From f3c8158773edf418833ff0032414433edbc6cd62 Mon Sep 17 00:00:00 2001 From: John Shelley Date: Thu, 15 Dec 2016 04:11:38 -0800 Subject: [PATCH] Android - ReactNativeHost getUseDeveloperSupport to public Summary: Currently React Native is opinionated in that the easiest approach is to extend ReactActivity. However to more easily allow integrating with existing application, we should allow some of the methods in ReactNativeHost to be public, and this is a very good first step. * There is no harm in making this public from what I can tell. * This allows `ReactNativeHost` to be more easily used outside of the `ReactActivity` and `ReactActivityDelegate` ecosystem. (A `ReactFragment` would be a good example) _No issues found_ **Test plan (required)** * Run any sample app and verify it still works. Make sure tests pass on both Travis and Circle CI. Closes https://github.com/facebook/react-native/pull/11329 Differential Revision: D4287429 Pulled By: AaaChiuuu fbshipit-source-id: 8cb76f3226aae3737af5f5bd6010d3eea8df9bfe --- .../src/main/java/com/facebook/react/ReactNativeHost.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/ReactNativeHost.java b/ReactAndroid/src/main/java/com/facebook/react/ReactNativeHost.java index 2e341460c3a576..57d7b45fc74ff9 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/ReactNativeHost.java +++ b/ReactAndroid/src/main/java/com/facebook/react/ReactNativeHost.java @@ -138,7 +138,7 @@ protected String getJSMainModuleName() { /** * Returns whether dev mode should be enabled. This enables e.g. the dev menu. */ - protected abstract boolean getUseDeveloperSupport(); + public abstract boolean getUseDeveloperSupport(); /** * Returns a list of {@link ReactPackage} used by the app.