From c93cbdf1b272cfd60124d9ddb4c52b58ca59d319 Mon Sep 17 00:00:00 2001
From: Dulmandakh <dulmandakh@gmail.com>
Date: Sat, 9 Feb 2019 02:36:02 -0800
Subject: [PATCH] Nonnull annotations for native modules (#23353)

Summary:
This adds Nonnull annotations for interfaces and classes used for native modules for Android, to improve Kotlin developer experience, but also code quality checks.

[Android] [Changed] - Nonnull annotations for native module interfaces
Pull Request resolved: https://github.com/facebook/react-native/pull/23353

Differential Revision: D14018181

Pulled By: mdvacca

fbshipit-source-id: 09a583860a6075e1d6f6df8f479369ae96497133
---
 .../src/main/java/com/facebook/react/ReactPackage.java      | 6 ++++--
 .../main/java/com/facebook/react/bridge/NativeModule.java   | 4 +++-
 .../facebook/react/bridge/ReactContextBaseJavaModule.java   | 3 ++-
 3 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/ReactAndroid/src/main/java/com/facebook/react/ReactPackage.java b/ReactAndroid/src/main/java/com/facebook/react/ReactPackage.java
index 0dd952216a8c09..527db0ace2e544 100644
--- a/ReactAndroid/src/main/java/com/facebook/react/ReactPackage.java
+++ b/ReactAndroid/src/main/java/com/facebook/react/ReactPackage.java
@@ -13,6 +13,8 @@
 import com.facebook.react.uimanager.ViewManager;
 import java.util.List;
 
+import javax.annotation.Nonnull;
+
 /**
  * Main interface for providing additional capabilities to the catalyst framework by couple of
  * different means:
@@ -32,10 +34,10 @@ public interface ReactPackage {
    * @param reactContext react application context that can be used to create modules
    * @return list of native modules to register with the newly created catalyst instance
    */
-  List<NativeModule> createNativeModules(ReactApplicationContext reactContext);
+  List<NativeModule> createNativeModules(@Nonnull ReactApplicationContext reactContext);
 
   /**
    * @return a list of view managers that should be registered with {@link UIManagerModule}
    */
-  List<ViewManager> createViewManagers(ReactApplicationContext reactContext);
+  List<ViewManager> createViewManagers(@Nonnull ReactApplicationContext reactContext);
 }
diff --git a/ReactAndroid/src/main/java/com/facebook/react/bridge/NativeModule.java b/ReactAndroid/src/main/java/com/facebook/react/bridge/NativeModule.java
index 44d65b11f53a9b..14224ca10a285c 100644
--- a/ReactAndroid/src/main/java/com/facebook/react/bridge/NativeModule.java
+++ b/ReactAndroid/src/main/java/com/facebook/react/bridge/NativeModule.java
@@ -9,6 +9,8 @@
 
 import com.facebook.proguard.annotations.DoNotStrip;
 
+import javax.annotation.Nonnull;
+
 
 /**
  * A native module whose API can be provided to JS catalyst instances.  {@link NativeModule}s whose
@@ -28,7 +30,7 @@ interface NativeMethod {
    * @return the name of this module. This will be the name used to {@code require()} this module
    * from javascript.
    */
-  String getName();
+  @Nonnull String getName();
 
   /**
    * This is called at the end of {@link CatalystApplicationFragment#createCatalystInstance()}
diff --git a/ReactAndroid/src/main/java/com/facebook/react/bridge/ReactContextBaseJavaModule.java b/ReactAndroid/src/main/java/com/facebook/react/bridge/ReactContextBaseJavaModule.java
index 00ff1173067613..0fe9ac13a591bf 100644
--- a/ReactAndroid/src/main/java/com/facebook/react/bridge/ReactContextBaseJavaModule.java
+++ b/ReactAndroid/src/main/java/com/facebook/react/bridge/ReactContextBaseJavaModule.java
@@ -7,6 +7,7 @@
 
 package com.facebook.react.bridge;
 
+import javax.annotation.Nonnull;
 import javax.annotation.Nullable;
 
 import android.app.Activity;
@@ -19,7 +20,7 @@ public abstract class ReactContextBaseJavaModule extends BaseJavaModule {
 
   private final ReactApplicationContext mReactApplicationContext;
 
-  public ReactContextBaseJavaModule(ReactApplicationContext reactContext) {
+  public ReactContextBaseJavaModule(@Nonnull ReactApplicationContext reactContext) {
     mReactApplicationContext = reactContext;
   }