From 9c3fa573379bb4824bbe02b5b5aa1ae3502772d8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Eloy=20Dur=C3=A1n?= Date: Wed, 22 Jan 2020 18:06:04 -0800 Subject: [PATCH] Remove FB copyright notices from iOS template (#27725) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Summary: Files that are to be part of the user’s project shouldn’t have FB copyright notices. There’s [one notice left](https://github.com/facebook/react-native/blob/66601e755fcad10698e61d20878d52194ad0e90c/template/android/app/src/debug/java/com/helloworld/ReactNativeFlipper.java#L2) in the `android` template, which is in a file that doesn’t seem to be intended to be changed by the user and so that seems fine to me. ## Changelog [iOS] [Removed] - Remove copyright notices from iOS application template Pull Request resolved: https://github.com/facebook/react-native/pull/27725 Test Plan: ```bash npx react-native init TestTemplateUpdates --template ~/Code/ReactNative/react-native cd ios xcodebuild -workspace TestTemplateUpdates.xcworkspace \ -scheme TestTemplateUpdates \ -destination 'platform=iOS Simulator,OS=latest,name=iPhone 8' build […] ** BUILD SUCCEEDED ** ``` Differential Revision: D19343386 Pulled By: TheSavior fbshipit-source-id: a78be5e5d2fdc2477adedb51d6bb3ff19845b75f --- template/ios/HelloWorld.xcodeproj/project.pbxproj | 9 ++++----- template/ios/HelloWorld/AppDelegate.h | 7 ------- template/ios/HelloWorld/AppDelegate.m | 7 ------- template/ios/HelloWorld/main.m | 7 ------- template/ios/HelloWorldTests/HelloWorldTests.m | 7 ------- template/ios/Swift.swift | 7 ------- 6 files changed, 4 insertions(+), 40 deletions(-) diff --git a/template/ios/HelloWorld.xcodeproj/project.pbxproj b/template/ios/HelloWorld.xcodeproj/project.pbxproj index 74cd1ff47ea3dc..3f65163e375dc7 100644 --- a/template/ios/HelloWorld.xcodeproj/project.pbxproj +++ b/template/ios/HelloWorld.xcodeproj/project.pbxproj @@ -244,7 +244,6 @@ isa = PBXProject; attributes = { LastUpgradeCheck = 0940; - ORGANIZATIONNAME = Facebook; TargetAttributes = { 00E356ED1AD99517003FC87E = { CreatedOnToolsVersion = 6.2; @@ -557,7 +556,7 @@ "-ObjC", "-lc++", ); - PRODUCT_BUNDLE_IDENTIFIER = "com.facebook.REACT.HelloWorld-tvOS"; + PRODUCT_BUNDLE_IDENTIFIER = "org.reactjs.native.example.HelloWorld-tvOS"; PRODUCT_NAME = "$(TARGET_NAME)"; SDKROOT = appletvos; TARGETED_DEVICE_FAMILY = 3; @@ -584,7 +583,7 @@ "-ObjC", "-lc++", ); - PRODUCT_BUNDLE_IDENTIFIER = "com.facebook.REACT.HelloWorld-tvOS"; + PRODUCT_BUNDLE_IDENTIFIER = "org.reactjs.native.example.HelloWorld-tvOS"; PRODUCT_NAME = "$(TARGET_NAME)"; SDKROOT = appletvos; TARGETED_DEVICE_FAMILY = 3; @@ -610,7 +609,7 @@ "-ObjC", "-lc++", ); - PRODUCT_BUNDLE_IDENTIFIER = "com.facebook.REACT.HelloWorld-tvOSTests"; + PRODUCT_BUNDLE_IDENTIFIER = "org.reactjs.native.example.HelloWorld-tvOSTests"; PRODUCT_NAME = "$(TARGET_NAME)"; SDKROOT = appletvos; TEST_HOST = "$(BUILT_PRODUCTS_DIR)/HelloWorld-tvOS.app/HelloWorld-tvOS"; @@ -636,7 +635,7 @@ "-ObjC", "-lc++", ); - PRODUCT_BUNDLE_IDENTIFIER = "com.facebook.REACT.HelloWorld-tvOSTests"; + PRODUCT_BUNDLE_IDENTIFIER = "org.reactjs.native.example.HelloWorld-tvOSTests"; PRODUCT_NAME = "$(TARGET_NAME)"; SDKROOT = appletvos; TEST_HOST = "$(BUILT_PRODUCTS_DIR)/HelloWorld-tvOS.app/HelloWorld-tvOS"; diff --git a/template/ios/HelloWorld/AppDelegate.h b/template/ios/HelloWorld/AppDelegate.h index 2726d5e13c7234..ef1de86a2a80ac 100644 --- a/template/ios/HelloWorld/AppDelegate.h +++ b/template/ios/HelloWorld/AppDelegate.h @@ -1,10 +1,3 @@ -/** - * Copyright (c) Facebook, Inc. and its affiliates. - * - * This source code is licensed under the MIT license found in the - * LICENSE file in the root directory of this source tree. - */ - #import #import diff --git a/template/ios/HelloWorld/AppDelegate.m b/template/ios/HelloWorld/AppDelegate.m index ef2ce0d46e9c59..6ebf0a680b219c 100644 --- a/template/ios/HelloWorld/AppDelegate.m +++ b/template/ios/HelloWorld/AppDelegate.m @@ -1,10 +1,3 @@ -/** - * Copyright (c) Facebook, Inc. and its affiliates. - * - * This source code is licensed under the MIT license found in the - * LICENSE file in the root directory of this source tree. - */ - #import "AppDelegate.h" #import diff --git a/template/ios/HelloWorld/main.m b/template/ios/HelloWorld/main.m index c316cf816e736a..b1df44b953ec48 100644 --- a/template/ios/HelloWorld/main.m +++ b/template/ios/HelloWorld/main.m @@ -1,10 +1,3 @@ -/** - * Copyright (c) Facebook, Inc. and its affiliates. - * - * This source code is licensed under the MIT license found in the - * LICENSE file in the root directory of this source tree. - */ - #import #import "AppDelegate.h" diff --git a/template/ios/HelloWorldTests/HelloWorldTests.m b/template/ios/HelloWorldTests/HelloWorldTests.m index e6ca332f45bde9..eabd5fd18227a5 100644 --- a/template/ios/HelloWorldTests/HelloWorldTests.m +++ b/template/ios/HelloWorldTests/HelloWorldTests.m @@ -1,10 +1,3 @@ -/** - * Copyright (c) Facebook, Inc. and its affiliates. - * - * This source code is licensed under the MIT license found in the - * LICENSE file in the root directory of this source tree. - */ - #import #import diff --git a/template/ios/Swift.swift b/template/ios/Swift.swift index af672d7867abbf..b1d706944c3158 100644 --- a/template/ios/Swift.swift +++ b/template/ios/Swift.swift @@ -1,10 +1,3 @@ -/** -* Copyright (c) Facebook, Inc. and its affiliates. -* -* This source code is licensed under the MIT license found in the -* LICENSE file in the root directory of this source tree. -*/ - // Flipper requires Swift, feel free to delete this file if you do not plan to use Flipper. import Foundation