From 4315106ac9cbcd7222749e0aa80eef6b96b4709d Mon Sep 17 00:00:00 2001 From: Paige Sun Date: Fri, 28 Jan 2022 23:38:05 -0800 Subject: [PATCH] Remove Static View Configs from bridge mode Summary: Changelog: [Internal] Remove all the MCs that enable SVCs in Fabric, because we'll only test SVCs in Bridgeless mode to simplify rollout. There were complications with enabling SVCs in Fabric at a previous rollout. Reviewed By: RSNara Differential Revision: D33861243 fbshipit-source-id: fdbfedce77f8bd1bab2a807237017787ae8bf7c1 --- .../com/facebook/react/config/ReactFeatureFlags.java | 3 --- .../com/facebook/react/fabric/FabricUIManager.java | 2 +- .../com/facebook/react/uimanager/UIManagerModule.java | 11 ----------- 3 files changed, 1 insertion(+), 15 deletions(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/config/ReactFeatureFlags.java b/ReactAndroid/src/main/java/com/facebook/react/config/ReactFeatureFlags.java index 1ccc2230fead00..b4ab457195a7a0 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/config/ReactFeatureFlags.java +++ b/ReactAndroid/src/main/java/com/facebook/react/config/ReactFeatureFlags.java @@ -64,9 +64,6 @@ public class ReactFeatureFlags { /** This feature flag enables logs for Fabric */ public static boolean enableFabricLogs = false; - /** Enables Static ViewConfig in RN Android native code. */ - public static boolean enableExperimentalStaticViewConfigs = false; - public static boolean enableRuntimeScheduler = false; public static boolean enableRuntimeSchedulerInTurboModule = false; diff --git a/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricUIManager.java b/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricUIManager.java index 8e2b4402de58e1..383b2e631022e8 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricUIManager.java +++ b/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricUIManager.java @@ -405,7 +405,7 @@ public void onCatalystInstanceDestroy() { ViewManagerPropertyUpdater.clear(); - // When using ReactFeatureFlags.enableExperimentalStaticViewConfigs enabled, FabriUIManager is + // When using StaticViewConfigs is enabled, FabriUIManager is // responsible for initializing and deallocating EventDispatcher. // TODO T83943316: Remove this IF once StaticViewConfigs are enabled by default if (mShouldDeallocateEventDispatcher) { diff --git a/ReactAndroid/src/main/java/com/facebook/react/uimanager/UIManagerModule.java b/ReactAndroid/src/main/java/com/facebook/react/uimanager/UIManagerModule.java index bcf11bf677c30d..57f383b81a6c5a 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/uimanager/UIManagerModule.java +++ b/ReactAndroid/src/main/java/com/facebook/react/uimanager/UIManagerModule.java @@ -40,7 +40,6 @@ import com.facebook.react.bridge.WritableMap; import com.facebook.react.common.MapBuilder; import com.facebook.react.common.ReactConstants; -import com.facebook.react.config.ReactFeatureFlags; import com.facebook.react.module.annotations.ReactModule; import com.facebook.react.uimanager.common.ViewUtil; import com.facebook.react.uimanager.debug.NotThreadSafeViewHierarchyUpdateDebugListener; @@ -288,16 +287,6 @@ private static Map createConstants( @Deprecated @Override public void preInitializeViewManagers(List viewManagerNames) { - if (ReactFeatureFlags.enableExperimentalStaticViewConfigs) { - for (String viewManagerName : viewManagerNames) { - mUIImplementation.resolveViewManager(viewManagerName); - } - // When Static view configs are enabled it is not necessary to pre-compute the constants for - // viewManagers, although the pre-initialization of viewManager objects is still necessary - // for performance reasons. - return; - } - Map constantsMap = new ArrayMap<>(); for (String viewManagerName : viewManagerNames) { WritableMap constants = computeConstantsForViewManager(viewManagerName);