From 176a578238566ad857c0911e127669f1ee82107d Mon Sep 17 00:00:00 2001 From: Valentin Shergin Date: Sun, 7 Jan 2018 18:21:46 -0800 Subject: [PATCH] '-[RCTSurfaceRootShadowView sizeThatFitsMinimumSize:]' was removed Summary: Because we already support this for all kinds of shadow views! Reviewed By: mmmulani Differential Revision: D6665636 fbshipit-source-id: ceee7e4952ede4bbe54aedde5545587a1d13ea5a --- React/Base/Surface/RCTSurface.mm | 1 + React/Base/Surface/RCTSurfaceRootShadowView.h | 3 -- React/Base/Surface/RCTSurfaceRootShadowView.m | 35 ------------------- 3 files changed, 1 insertion(+), 38 deletions(-) diff --git a/React/Base/Surface/RCTSurface.mm b/React/Base/Surface/RCTSurface.mm index 9624663afba403..c67ba985c8a6e8 100644 --- a/React/Base/Surface/RCTSurface.mm +++ b/React/Base/Surface/RCTSurface.mm @@ -15,6 +15,7 @@ #import "RCTAssert.h" #import "RCTBridge+Private.h" #import "RCTBridge.h" +#import "RCTShadowView+Layout.h" #import "RCTSurfaceDelegate.h" #import "RCTSurfaceRootShadowView.h" #import "RCTSurfaceRootShadowViewDelegate.h" diff --git a/React/Base/Surface/RCTSurfaceRootShadowView.h b/React/Base/Surface/RCTSurfaceRootShadowView.h index f681e67eb0374d..86b12c393f0c46 100644 --- a/React/Base/Surface/RCTSurfaceRootShadowView.h +++ b/React/Base/Surface/RCTSurfaceRootShadowView.h @@ -22,9 +22,6 @@ @property (nonatomic, weak) id delegate; -- (CGSize)sizeThatFitsMinimumSize:(CGSize)minimumSize - maximumSize:(CGSize)maximumSize; - /** * Layout direction (LTR or RTL) inherited from native environment and * is using as a base direction value in layout engine. diff --git a/React/Base/Surface/RCTSurfaceRootShadowView.m b/React/Base/Surface/RCTSurfaceRootShadowView.m index 3b98c6d7984064..2c762fa658c097 100644 --- a/React/Base/Surface/RCTSurfaceRootShadowView.m +++ b/React/Base/Surface/RCTSurfaceRootShadowView.m @@ -76,41 +76,6 @@ - (void)calculateLayoutWithMinimumSize:(CGSize)minimumSize maximumSize:(CGSize)m return viewsWithNewFrame; } -- (CGSize)sizeThatFitsMinimumSize:(CGSize)minimumSize - maximumSize:(CGSize)maximumSize -{ - // Positive case where requested constraind are aready enforced. - if (CGSizeEqualToSize(minimumSize, _minimumSize) && - CGSizeEqualToSize(maximumSize, _maximumSize)) { - // We stil need to call `calculateLayoutWithMinimumSize:maximumSize` - // mehtod though. - [self calculateLayoutWithMinimumSize:_minimumSize - maximumSize:_maximumSize]; - - YGNodeRef yogaNode = self.yogaNode; - return CGSizeMake(YGNodeLayoutGetWidth(yogaNode), YGNodeLayoutGetHeight(yogaNode)); - } - - // Generic case, where requested constraind are different from enforced. - - // Applying given size constraints. - [self calculateLayoutWithMinimumSize:minimumSize - maximumSize:maximumSize]; - - YGNodeRef yogaNode = self.yogaNode; - CGSize fittingSize = - CGSizeMake(YGNodeLayoutGetWidth(yogaNode), YGNodeLayoutGetHeight(yogaNode)); - - // Reverting size constraints. - [self calculateLayoutWithMinimumSize:_minimumSize - maximumSize:_maximumSize]; - - return CGSizeMake( - MAX(minimumSize.width, MIN(maximumSize.width, fittingSize.width)), - MAX(minimumSize.height, MIN(maximumSize.height, fittingSize.height)) - ); -} - - (void)setMinimumSize:(CGSize)minimumSize maximumSize:(CGSize)maximumSize { if (CGSizeEqualToSize(minimumSize, _minimumSize) &&