From 15b2353382c46dc5f0130ff44b9deb6a2361e3e5 Mon Sep 17 00:00:00 2001 From: Kevin Gozali Date: Thu, 29 Aug 2019 14:28:51 -0700 Subject: [PATCH] iOS Pods: added missing deps for React-CoreModules Summary: This is needed for use_frameworks! support with CocoaPods. Also, with recent changes to RCTImageLoader etc (moved to CoreModules), we need to add a dep to `React-RCTImage` pod. If this approach works for 0.61 branch as well, it should be beneficial to pick. Note that https://github.com/facebook/react-native/pull/26151 attempts to fix similar things, but in 0.61 branch, not master. Reviewed By: axe-fb Differential Revision: D17120352 fbshipit-source-id: ca96a7a61a6422a6f9fc3a4bf3add51e6f33f4f1 --- RNTester/Podfile.lock | 4 +++- React/CoreModules/React-CoreModules.podspec | 2 ++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/RNTester/Podfile.lock b/RNTester/Podfile.lock index cab692d2f3fd60..7357c2f0d611c5 100644 --- a/RNTester/Podfile.lock +++ b/RNTester/Podfile.lock @@ -172,7 +172,9 @@ PODS: - React-CoreModules (1000.0.0): - FBReactNativeSpec (= 1000.0.0) - Folly (= 2018.10.22.00) + - RCTTypeSafety (= 1000.0.0) - React-Core/CoreModulesHeaders (= 1000.0.0) + - React-RCTImage (= 1000.0.0) - ReactCommon/turbomodule/core (= 1000.0.0) - React-cxxreact (1000.0.0): - boost-for-react-native (= 1.63.0) @@ -356,7 +358,7 @@ SPEC CHECKSUMS: React: 28a654b69575941571c073a656bc06795825e7f7 React-ART: a5da06a892342d03896e0db45a7072525981f63c React-Core: 47b8ab211d9325292811e62ee23c54b464853111 - React-CoreModules: 38d8cc34497674ae3d411e644a9b17ad75ef3f74 + React-CoreModules: 96b2f1e0b84493e6c1b7f3bb21357f24fdcfce2f React-cxxreact: 7c4242192149ce0205b53efaa03e3bf86ba4337c React-jsi: 98d1f9d8a79d2720ba6a44c2d928a77f315b7e4f React-jsiexecutor: c0ab8c80a6e88380d63f583690a50d4a723b47b5 diff --git a/React/CoreModules/React-CoreModules.podspec b/React/CoreModules/React-CoreModules.podspec index 0b4c255ee7c749..5c62b379dec386 100644 --- a/React/CoreModules/React-CoreModules.podspec +++ b/React/CoreModules/React-CoreModules.podspec @@ -40,6 +40,8 @@ Pod::Spec.new do |s| s.dependency "FBReactNativeSpec", version s.dependency "Folly", folly_version + s.dependency "RCTTypeSafety", version s.dependency "React-Core/CoreModulesHeaders", version + s.dependency "React-RCTImage", version s.dependency "ReactCommon/turbomodule/core", version end