From c00aaa4b4e09b42d196427216f07fe891c2a3405 Mon Sep 17 00:00:00 2001 From: Matthew Saltus Date: Fri, 23 Aug 2024 10:44:54 -0700 Subject: [PATCH] Fix StatusTypeEnum bug Summary: `StatusType::ENUM_COUNT` is used to bound the valid enums but its not the last one... https://www.internalfb.com/code/fbsource/[b40ae6818e8b01d0e37ec0d35afe8f45269c73d1]/fbcode/proxygen/lib/http/StatusTypeEnum.cpp?lines=19-26 Differential Revision: D61672203 fbshipit-source-id: 5097fa47415f0081005c29d3ef2d65b85dc45b31 --- proxygen/lib/http/StatusTypeEnum.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/proxygen/lib/http/StatusTypeEnum.h b/proxygen/lib/http/StatusTypeEnum.h index 631ef49328..42c03ac02a 100644 --- a/proxygen/lib/http/StatusTypeEnum.h +++ b/proxygen/lib/http/StatusTypeEnum.h @@ -55,7 +55,8 @@ namespace proxygen { x(manifest_missing_representation), x(manifest_with_0_bitrate), \ x(manifest_with_no_tracks), x(manifest_with_wrong_track), \ x(cache_lease_queue_hard_timeout), x(cache_purge), x(cache_error), \ - x(proxy_cache_fill_shed), x(ENUM_COUNT), x(takedown_direct_response) + x(proxy_cache_fill_shed), x(takedown_direct_response), \ + /* ENUM_COUNT MUST BE THE FINAL ENUM */ x(ENUM_COUNT) #define STATUS_TYPE_ENUM(statusType) statusType