Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Add tests to ensure that all inter-package dependencies are declared #6572

Closed
etrepum opened this issue Aug 28, 2024 · 1 comment · Fixed by #6574
Closed

Feature: Add tests to ensure that all inter-package dependencies are declared #6572

etrepum opened this issue Aug 28, 2024 · 1 comment · Fixed by #6574
Labels
enhancement Improvement over existing feature

Comments

@etrepum
Copy link
Collaborator

etrepum commented Aug 28, 2024

Description

Due to the way the monorepo builds itself, our tooling does not catch undeclared inter-module dependencies such as #6569

Impact

When the implicit source dependencies of a package changes we should get an error to fix the package.json accordingly
@etrepum etrepum added the enhancement Improvement over existing feature label Aug 28, 2024
@ivailop7
Copy link
Collaborator

Yep, missed that one

@etrepum etrepum mentioned this issue Aug 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improvement over existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[*] Feature: Check undeclared dependencies in build etrepum/lexical
2 participants
@etrepum @ivailop7