Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Excalidraw example is broken #4673

Closed
bitofbreeze opened this issue Jun 18, 2023 · 3 comments · Fixed by #4684
Closed

Bug: Excalidraw example is broken #4673

bitofbreeze opened this issue Jun 18, 2023 · 3 comments · Fixed by #4684

Comments

@bitofbreeze
Copy link

The Excalidraw plugin example is broken https://lexical.dev/docs/demos/plugins/excalidraw

Lexical version: 0.5.0

Steps To Reproduce

  1. Open the Excalidraw plugin example https://lexical.dev/docs/demos/plugins/excalidraw

Link to code example: https://codesandbox.io/s/lexical-excalidraw-plugin-example-4q08cv?from-embed

The current behavior

Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: undefined. You likely forgot to export your component from the file it's defined in, or you might have mixed up default and named imports.

Check the render method of `ExcalidrawModal`.

The expected behavior

No error

@ivailop7
Copy link
Collaborator

Most of those code sandbox examples are broken, because they are outdated and I'm not sure who owns most of them. @acywatson @zurfyx shall we remove all code sandboxes from the documentation, quite a few of them are outdated and don't work. Maintaining them is quite hard due to the ownership of the sandboxes. Yet the value they add isn't high, since we have the playground. What do you think?

@bitofbreeze
Copy link
Author

I know you can make codesandbox pull from this repo's examples folder so they are always kept up to date there. Would that help, or is the issue that the examples in this repo are not being maintained?

@thegreatercurve
Copy link
Contributor

From what I've seen, these don't get a huge number of views compared to the main playground. It's a bit of a manual process to update them as well which is the reason they're breaking.

I'd be happy to remove these if everyone is just using the playground any way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants