New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: LexicalCharacterLimitPlugin CHARACTER_LIMIT - 5 (hardcoded) cant be changed #3648

Closed

xjjda22 opened this issue Dec 28, 2022 · 1 comment

Contributor

xjjda22 commented Dec 28, 2022

Lexical version:v0.7.5

Steps To Reproduce

try lexical playground and enable char limit from the options
CHARACTER_LIMIT is fixed to 5 and cant be changed

Link to code example:

lexical/packages/lexical-react/src/LexicalCharacterLimitPlugin.tsx

Line 15 in 6e65c98

const CHARACTER_LIMIT = 5;

The expected behavior

CHARACTER_LIMIT should be through the plugin props, similar to MaxLengthPlugin

reference to CharacterLimitPlugin -

lexical/packages/lexical-playground/src/Editor.tsx

Line 217 in 6e65c98

<CharacterLimitPlugin charset={isCharLimit ? 'UTF-16' : 'UTF-8'} />

reference to MaxLengthPlugin -

lexical/packages/lexical-playground/src/Editor.tsx

Line 120 in 6e65c98

{isMaxLength && <MaxLengthPlugin maxLength={30} />}

Collaborator

trueadm commented Jan 3, 2023

Fixed in #3649

trueadm closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment