Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not transform internally imported files #9900

Merged
merged 3 commits into from
Apr 28, 2020

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Apr 27, 2020

Summary

Any internal module should never be transformed at runtime, so let's just bail early rather than having ScriptTransformer skip them (or not, which is super wasteful).

Test plan

Green CI

@SimenB
Copy link
Member Author

SimenB commented Apr 27, 2020

Hah, OOM on circus 🙈

@SimenB
Copy link
Member Author

SimenB commented Apr 27, 2020

Does this OOM due to the cache thing? Probably... I can skip it

@SimenB SimenB force-pushed the skip-transforming-internal-requires branch from e234611 to 3c87e31 Compare April 28, 2020 11:17
@SimenB SimenB force-pushed the skip-transforming-internal-requires branch from 3c87e31 to 5cb78d8 Compare April 28, 2020 12:28
@codecov-io
Copy link

Codecov Report

Merging #9900 into master will increase coverage by 0.02%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9900      +/-   ##
==========================================
+ Coverage   64.41%   64.43%   +0.02%     
==========================================
  Files         291      291              
  Lines       12410    12417       +7     
  Branches     3059     3062       +3     
==========================================
+ Hits         7994     8001       +7     
  Misses       3770     3770              
  Partials      646      646              
Impacted Files Coverage Δ
packages/jest-runtime/src/index.ts 58.62% <80.00%> (+0.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5db005f...5cb78d8. Read the comment docs.

@SimenB SimenB merged commit e281d53 into jestjs:master Apr 28, 2020
@SimenB SimenB deleted the skip-transforming-internal-requires branch April 28, 2020 13:26
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants