Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website: Update pictures of reports when matchers fail #9214

Merged
merged 5 commits into from
Jan 22, 2020

Conversation

pedrottimark
Copy link
Contributor

Summary

Update 9 pictures for Jest 25

  • Use matcher name as button label and file name in matchers folder
  • Increase assortment of matchers because mock-spy is in preceding section and inline snapshot looks so similar to snapshot
  • Crop to omit stack because realistic and repeatable report is hard enough without it

Test plan

Build web site locally

@pedrottimark
Copy link
Contributor Author

Pictures of home page baseline above and improved below:

__home baseline

__home improved

@pedrottimark
Copy link
Contributor Author

Pictures of Snapshot Testing baseline above and improved below:

__snapshot baseline

__snapshot improved

@SimenB
Copy link
Member

SimenB commented Nov 20, 2019

Ah, wonderful stuff!

@codecov-io
Copy link

codecov-io commented Nov 20, 2019

Codecov Report

Merging #9214 into master will decrease coverage by 0.12%.
The diff coverage is 51.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9214      +/-   ##
==========================================
- Coverage   65.08%   64.96%   -0.13%     
==========================================
  Files         281      283       +2     
  Lines       11864    12104     +240     
  Branches     2921     2990      +69     
==========================================
+ Hits         7722     7863     +141     
- Misses       3514     3604      +90     
- Partials      628      637       +9
Impacted Files Coverage Δ
e2e/v8-coverage/no-sourcemap/x.css 100% <ø> (ø)
e2e/coverage-remapping/covered.ts 100% <ø> (ø) ⬆️
packages/expect/src/matchers.ts 96.86% <ø> (ø) ⬆️
packages/jest-circus/src/utils.ts 14.72% <ø> (-0.66%) ⬇️
packages/test-utils/src/ConditionalTest.ts 0% <ø> (ø) ⬆️
packages/jest-config/src/ValidConfig.ts 100% <ø> (ø) ⬆️
e2e/coverage-transform-instrumented/covered.js 100% <ø> (ø) ⬆️
packages/jest-config/src/Defaults.ts 100% <ø> (ø) ⬆️
packages/jest-haste-map/src/constants.ts 100% <ø> (ø) ⬆️
packages/jest-config/src/normalize.ts 77.74% <ø> (ø) ⬆️
... and 49 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da2328a...7c36cc3. Read the comment docs.

@SimenB
Copy link
Member

SimenB commented Nov 20, 2019

Should we hold off on merging this until Jest 25 is released?

@thymikee
Copy link
Collaborator

thymikee commented Nov 20, 2019

"master" is not shown by default, so people will still see v24.9 until 25 is released. I'm good with merging it now
EDIT: oh, I haven't thought about it, but images are not versioned 🤦‍♂ let's wait then

@SimenB
Copy link
Member

SimenB commented Nov 20, 2019

The index page is the same for all versions 🙂

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants